From: Greg KH <gregkh@linuxfoundation.org>
To: Geon Si Jeong <gshark.jeong@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip
Date: Tue, 3 Apr 2012 15:09:46 -0700 [thread overview]
Message-ID: <20120403220946.GA6022@kroah.com> (raw)
In-Reply-To: <1333089508-8501-2-git-send-email-gshark.jeong@gmail.com>
On Fri, Mar 30, 2012 at 03:38:28PM +0900, Geon Si Jeong wrote:
> It is a simple driver for LM3556 Chip(Texas Instruments)
> LM3556 :
> The LM3556 is a 4 MHz fixed-frequency synchronous boost
> converter plus 1.5A constant current driver for a high-current white LED.
> Datasheet: www.national.com/ds/LM/LM3556.pdf
>
> Tested on OMAP4430
>
> Signed-off-by: Geon Si Jeong <gshark.jeong@gmail.com>
> ---
> drivers/leds/Kconfig | 9 +
> drivers/leds/Makefile | 2 +-
> drivers/leds/leds-lm3556.c | 462 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/leds-lm3556.h | 242 ++++++++++++++++++++++
Why does this .h file have to be in include/linux/ ?
Why does it need to be a .h file at all? Why can't it be part of the .c
file?
Only put files in include/linux/ that other files outside of your local
directory, need to access, and only put stuff in those files that other
files need to have.
thanks,
greg k-h
prev parent reply other threads:[~2012-04-03 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 6:38 [PATCH 0/1] " Geon Si Jeong
2012-03-30 6:38 ` [PATCH 1/1] " Geon Si Jeong
2012-03-30 18:26 ` Andrew Morton
2012-03-30 18:41 ` Andrew Morton
2012-04-01 3:37 ` Shuah Khan
2012-04-06 23:28 ` Andrew Morton
2012-03-30 18:56 ` Wolfram Sang
2012-03-31 21:09 ` Mark Brown
2012-04-03 22:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403220946.GA6022@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.jeong@ti.com \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome