Re: [PATCH] usb: musb: make modules behave better

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Kishon,

On Mon, Apr 02, 2012 at 10:33:10PM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi,
> 
> On Mon, Apr 2, 2012 at 8:04 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > Hi Felipe,
> >
> > On Thu, Jan 26, 2012 at 12:45:49PM +0200, Felipe Balbi wrote:
> >> There's really no point in doing all that
> >> initcall trickery when we can safely let
> >> udev handle module probing for us.
> >>
> >> Remove all of that trickery, by moving everybody
> >> to module_init() and making proper use of
> >> platform_device_register() rather than
> >> platform_device_probe().
> >>
> >> Signed-off-by: Felipe Balbi <balbi@ti.com>
> >> ---
> >>
> >> Because this falls into the "has never worked before" category
> >> I will be sending this only on the next merge window. This
> >> also gives people enough time to complain about any mistakes
> >> on the patch.
> >
> > This patch looks correct and right to me, but it breaks musb when it's
> > compiled into the kernel, at least on the Nokia N950. I haven't yet figured
> > out exactly why, though.
> 
> Is it an abort?
> You can use the patch which I've sent to the list last week for fixing it.
> http://www.spinics.net/lists/linux-usb/msg60603.html.

It wasn't abort --- the USB simply refused to work. I tested your patch and
it does indeed fix the problem I had.

Feel free to add:

Tested-by: Sakari Ailus <sakari.ailus@iki.fi>

Cheers,

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	jabber/XMPP/Gmail: sailus@retiisi.org.uk