From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, andi@firstfloor.org
Subject: Re: [RFCv2 0/8] perf tool: Add new event group management
Date: Wed, 4 Apr 2012 23:21:10 +0200 [thread overview]
Message-ID: <20120404212109.GA11460@m.brq.redhat.com> (raw)
In-Reply-To: <1333574176-11388-1-git-send-email-jolsa@redhat.com>
oops, forgot to add that this patchset is based on another
one I sent just recently..
http://marc.info/?l=linux-kernel&m=133357111816870&w=2
jirka
On Wed, Apr 04, 2012 at 11:16:08PM +0200, Jiri Olsa wrote:
> hi,
> adding support for creating event groups based on the way they
> are specified on the command line.
>
> - added 'group=...' syntax to group events (patches 1-5).
> I think this part is quite ready.
>
> - added 'group:1=...' syntax to specify which event to sample (leader)
> and use PERF_SAMPLE_READ and PERF_FORMAT_GROUP to read all siblings
> on every leader's events (patches 6-8).
> Currently it is only possible to display siblings values by
> 'perf report -D' PERF_SAMPLE_READ dump output containing only perf
> internal IDs displayed.. so not very usefull. But I was hoping to
> straighten up the data design/directions before I touch the gui.
>
>
> Attached patches:
> 1/8 perf, tool: Add support to parse event group syntax
> 2/8 perf, tool: Enable grouping logic for parsed events
> 3/8 perf: Add PERF_EVENT_IOC_ID ioctl to return event ID
> 4/8 perf, tool: Use PERF_EVENT_IOC_ID perf ioctl to read event id
> 5/8 perf, tool: Separate 'mem:' event scanner bits
> 6/8 perf, tool: Add modifier support to group event syntax
> 7/8 perf, tool: Add support for parsing PERF_SAMPLE_READ
> 8/8 perf, tool: Enable sampling on specified event group leader
>
> thanks for comments,
> jirka
> ---
> include/linux/perf_event.h | 1 +
> kernel/events/core.c | 9 +++
> tools/perf/builtin-record.c | 13 ++---
> tools/perf/builtin-stat.c | 13 ++---
> tools/perf/builtin-test.c | 12 ++--
> tools/perf/builtin-top.c | 12 +---
> tools/perf/util/event.h | 21 ++++++-
> tools/perf/util/evlist.c | 120 +++++++++++++++++++++++++++--------
> tools/perf/util/evlist.h | 8 ++-
> tools/perf/util/evsel.c | 94 +++++++++++++++++++++-------
> tools/perf/util/evsel.h | 16 ++---
> tools/perf/util/parse-events-test.c | 93 ++++++++++++++++++++++++++-
> tools/perf/util/parse-events.c | 6 ++
> tools/perf/util/parse-events.h | 1 +
> tools/perf/util/parse-events.l | 39 +++++++++++-
> tools/perf/util/parse-events.y | 66 +++++++++++++++++---
> tools/perf/util/python.c | 10 ++-
> tools/perf/util/session.c | 42 ++++++++++++
> tools/perf/util/session.h | 5 +-
> 19 files changed, 476 insertions(+), 105 deletions(-)
next prev parent reply other threads:[~2012-04-04 21:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 21:16 Jiri Olsa
2012-04-04 21:16 ` [PATCH 1/8] perf, tool: Add support to parse event group syntax Jiri Olsa
2012-04-04 21:16 ` [PATCH 2/8] perf, tool: Enable grouping logic for parsed events Jiri Olsa
2012-04-04 21:16 ` [PATCH 3/8] perf: Add PERF_EVENT_IOC_ID ioctl to return event ID Jiri Olsa
2012-04-04 21:16 ` [PATCH 4/8] perf, tool: Use PERF_EVENT_IOC_ID perf ioctl to read event id Jiri Olsa
2012-04-04 21:16 ` [PATCH 5/8] perf, tool: Separate 'mem:' event scanner bits Jiri Olsa
2012-04-11 13:28 ` Robert Richter
2012-04-11 14:33 ` Jiri Olsa
2012-04-13 17:02 ` Robert Richter
2012-04-04 21:16 ` [PATCH 6/8] perf, tool: Add modifier support to group event syntax Jiri Olsa
2012-04-04 21:16 ` [PATCH 7/8] perf, tool: Add support for parsing PERF_SAMPLE_READ Jiri Olsa
2012-04-04 21:16 ` [PATCH 8/8] perf, tool: Enable sampling on specified event group leader Jiri Olsa
2012-04-04 21:21 ` Jiri Olsa [this message]
2012-04-15 15:16 ` [RFCv2 0/8] perf tool: Add new event group management Peter Zijlstra
2012-04-16 12:16 ` Jiri Olsa
2012-04-16 14:23 ` Peter Zijlstra
2012-04-16 15:26 ` Peter Zijlstra
2012-04-16 15:37 ` Jiri Olsa
2012-04-17 2:16 ` Namhyung Kim
2012-04-17 9:09 ` Namhyung Kim
2012-04-17 9:33 ` Jiri Olsa
2012-05-25 22:36 ` Andi Kleen
2012-05-26 12:38 ` Jiri Olsa
2012-05-26 19:23 ` Andi Kleen
2012-05-27 7:56 ` Ulrich Drepper
2012-05-27 15:08 ` Andi Kleen
2012-05-28 19:21 ` Jiri Olsa
2012-05-29 8:39 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404212109.GA11460@m.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome