Re: [PATCHv3 1/3] misc: clean up bmp085 driver

[Eric Andersson <eric.andersson@unixphere.com>]

Hi Joe,

On 12:55 Wed 04 Apr     , Joe Perches wrote:
> On Wed, 2012-04-04 at 21:45 +0200, Eric Andersson wrote:
> > This patch includes various cleaning of the bmp085 driver including:
> > - Whitespaces and alignment fixes
> > - Minor typos
> > - Consistency fixes
> 
> just some more trivial things:
> 
> > diff --git a/drivers/misc/bmp085.c b/drivers/misc/bmp085.c
> []
> > @@ -222,8 +217,10 @@ exit:
> >  /*
> >   * This function starts the pressure measurement and returns the value
> >   * in millibar. Since the pressure depends on the ambient temperature,
> > - * a temperature measurement is executed if the last known value is older
> > - * than one second.
> > + * a temperature measurement is executed according to the given temperature
> > + * measurememt period (default is 1 sec boundary). This period could vary
> 
> typo: measurement
> 
> > + * and needs to be adjusted according to the sensor environment, i.e. if big
> > + * temperature variations then the temperature needs to be read out often.
> 
> > @@ -386,25 +387,23 @@ static int bmp085_detect(struct i2c_client *client, struct i2c_board_info *info)
> >  
> >  static int bmp085_init_client(struct i2c_client *client)
> []
> > -	dev_info(&data->client->dev, "BMP085 ver. %d.%d found.\n",
> > -			(version & 0x0F), (version & 0xF0) >> 4);
> 
> Why remove the "version" output?

The version register is actually not an official register and is subject to
change in the future.

I'll fix the typos in next version!

Thanks!

-- 
Best regards,
 Eric

http://www.unixphere.com