On Thu, Apr 05, 2012 at 02:07:36PM +0800, Axel Lin wrote: > Not every regulator driver should implement set_voltage_sel callback. > See commit e8eef82 > "regulator: Provide a selector based set_voltage_sel() operation". > > For rc5t583, the regulator voltage can be mapped onto selector values with a > simple calculation, thus implement set_voltage is better than set_voltage_sel. Applied, thanks.