From: Francois Romieu <romieu@fr.zoreil.com>
To: "Svenning Sørensen" <sss@secomea.com>
Cc: Bjarke Istrup Pedersen <gurligebis@gentoo.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Andreas Mohr <andi@lisas.de>
Subject: Re: via-rhine: Problem with lost link after a while
Date: Thu, 12 Apr 2012 00:21:24 +0200 [thread overview]
Message-ID: <20120411222124.GA20605@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <4F8553BF.6030303@secomea.com>
Svenning Sørensen <sss@secomea.com> :
[...]
> Regarding the "Tx descriptor busy" test: no, I didn't see it
> trigger, I just put it there just in case because I suspected there
> could be a race due to the lock-free tx path.
> But I'm glad if you're confident that it can't happen :)
Almost :o)
Without the patch it may happen in mainline. Once the napi Tx completion
function checks if queueing is stopped before enabling it, it should not
happen though. The patch should fix the race where queuing is not enabled
as well.
That being said, I would welcome a pony^W^W some testing on a multi-core
system with lots of Tx and enough irq from a different (non via-rhine)
source to starve the softirq processing.
--
Ueimor
next prev parent reply other threads:[~2012-04-11 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 15:03 Bjarke Istrup Pedersen
2012-04-10 20:42 ` Francois Romieu
2012-04-10 21:15 ` Bjarke Istrup Pedersen
2012-04-10 22:55 ` Francois Romieu
2012-04-10 23:58 ` Bjarke Istrup Pedersen
2012-04-11 9:49 ` Svenning Sørensen
2012-04-11 22:21 ` Francois Romieu [this message]
2012-04-13 6:16 ` Bjarke Istrup Pedersen
2012-04-14 10:06 ` Francois Romieu
2012-04-14 15:10 ` Bjarke Istrup Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411222124.GA20605@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=andi@lisas.de \
--cc=gurligebis@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sss@secomea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®