From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966060Ab2DLVjo (ORCPT ); Thu, 12 Apr 2012 17:39:44 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:41932 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966044Ab2DLVjn (ORCPT ); Thu, 12 Apr 2012 17:39:43 -0400 Date: Thu, 12 Apr 2012 17:37:07 -0400 (EDT) Message-Id: <20120412.173707.2114402833197161386.davem@davemloft.net> To: eldad@fogrefinery.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ipv6/exthdrs.c: Strict PadN option checking From: David Miller In-Reply-To: <1334266320-12297-1-git-send-email-eldad@fogrefinery.com> References: <1334266320-12297-1-git-send-email-eldad@fogrefinery.com> X-Mailer: Mew version 6.4 on Emacs 24.0.95 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 12 Apr 2012 14:37:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eldad Zack Date: Thu, 12 Apr 2012 23:31:59 +0200 > Added strict checking of PadN, as PadN can be used to increase header > size and thus push the protocol header into the 2nd fragment. > > PadN is used to align the options within the Hop-by-Hop or > Destination Options header to 64-bit boundaries. The maximum valid > size is thus 7 bytes. > RFC 4942 recommends to actively check the "payload" itself and > ensure that it contains only zeroes. > > See also RFC 4942 section 2.1.9.5. > > Signed-off-by: Eldad Zack Applied after fixing up the comment formatting. Thanks.