From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: [Regression + patch] i915 / PM: System resume broken on 945GM
Date: Thu, 12 Apr 2012 00:12:46 +0200 [thread overview]
Message-ID: <201204120012.46826.rjw@sisk.pl> (raw)
Hi Chris,
Unfortunately, your commit
commit 7dd4906586274f3945f2aeaaa5a33b451c3b4bba
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Mar 21 10:48:18 2012 +0000
drm/i915: Mark untiled BLT commands as fenced on gen2/3
breaks system resume on my Toshiba Portege R500 (945GM) which hangs hard
during or right after returning to X.
The appended patch fixes the issue for me, FWIW.
Thanks,
Rafael
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/gpu/drm/i915/i915_gem_execbuffer.c
===================================================================
--- linux.orig/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ linux/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -498,7 +498,7 @@ pin_and_fence_object(struct drm_i915_gem
if (ret)
goto err_unpin;
}
- obj->pending_fenced_gpu_access = true;
+ obj->pending_fenced_gpu_access = need_fence;
}
}
next reply other threads:[~2012-04-11 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 22:12 Rafael J. Wysocki [this message]
2012-04-11 22:20 ` Greg Kroah-Hartman
2012-04-11 22:56 ` Rafael J. Wysocki
2012-04-11 23:01 ` Greg Kroah-Hartman
2012-04-11 22:33 ` Woody Suwalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204120012.46826.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®