From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>, Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix modpost failures in fedora 17
Date: Thu, 12 Apr 2012 21:13:04 +0200 [thread overview]
Message-ID: <20120412191304.GA30472@merkur.ravnborg.org> (raw)
In-Reply-To: <20120412.143730.258982831585270742.davem@davemloft.net>
On Thu, Apr 12, 2012 at 02:37:30PM -0400, David Miller wrote:
>
> The symbol table on x86-64 starts to have entries that have names
> like:
>
> _GLOBAL__sub_I_65535_0___mod_x86cpu_device_table
>
> They are of type STT_FUNCTION and this one had a length of 18. This
> matched the device ID validation logic and it barfed because the
> length did not meet the device type's criteria.
>
> --------------------
> FATAL: arch/x86/crypto/aesni-intel: sizeof(struct x86cpu_device_id)=16 is not a modulo of the size of section __mod_x86cpu_device_table=18.
> Fix definition of struct x86cpu_device_id in mod_devicetable.h
> --------------------
>
> These are some kind of compiler tool internal stuff being emitted and
> not something we want to inspect in modpost's device ID table
> validation code.
>
> So skip the symbol if it is not of type STT_OBJECT.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I assume this is stable material too?
In other words we should add:
Cc: stable@vger.kernel.org
Michal - I assume you take this.
Sam
next prev parent reply other threads:[~2012-04-12 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 18:37 David Miller
2012-04-12 19:13 ` Sam Ravnborg [this message]
2012-04-12 19:23 ` David Miller
2012-04-18 19:31 ` David Miller
2012-04-18 19:51 ` Michal Marek
2012-04-22 4:18 ` David Miller
2012-04-22 6:03 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412191304.GA30472@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®