From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
x86@kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] Add CONFIG_READABLE_ASM
Date: Thu, 12 Apr 2012 21:52:48 +0200 [thread overview]
Message-ID: <20120412195248.GA30631@merkur.ravnborg.org> (raw)
In-Reply-To: <CAMuHMdXfpvprGD18_YYyctfrAk6iRJonWFGFRf9oSaH0u0zfhw@mail.gmail.com>
On Thu, Apr 12, 2012 at 09:47:19PM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Thu, Apr 12, 2012 at 21:40, Sam Ravnborg <sam@ravnborg.org> wrote:
> > On Thu, Apr 12, 2012 at 09:08:36PM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Mar 28, 2012 at 20:51, Andi Kleen <andi@firstfloor.org> wrote:
> >> > +ifdef CONFIG_READABLE_ASM
> >> > +# Disable optimizations that make assembler listings hard to read.
> >> > +# reorder blocks reorders the control in the function
> >> > +# ipa clone creates specialized cloned functions
> >> > +# partial inlining inlines only parts of functions
> >> > +KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks,) \
> >> > + $(call cc-option,-fno-ipa-cp-clone,) \
> >> > + $(call cc-option,-fno-partial-inlining)
> >> > +endif
> >
> > Could people move to this century and drop these ugly "\" line-continuations please...
> > People seems to get along in C without but think they should be used in Makefiles..
>
> Not without an additional patch for make:
>
> Makefile:575: *** missing separator (did you mean TAB instead of 8
> spaces?). Stop.
I meant like this:
KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks)
KBUILD_CFLAGS += $(call cc-disable-warning,-fno-ipa-cp-clone)
KBUILD_CFLAGS += $(call cc-option,-fno-partial-inlining)
Sam
next prev parent reply other threads:[~2012-04-12 19:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 18:51 [PATCH 1/2] x86: Use -mno-avx when available Andi Kleen
2012-03-28 18:51 ` [PATCH 2/2] Add CONFIG_READABLE_ASM Andi Kleen
2012-03-30 17:41 ` [tip:x86/cleanups] debug: " tip-bot for Andi Kleen
2012-04-12 19:08 ` [PATCH 2/2] " Geert Uytterhoeven
2012-04-12 19:36 ` H. Peter Anvin
2012-04-12 19:42 ` Geert Uytterhoeven
2012-04-12 19:40 ` Sam Ravnborg
2012-04-12 19:47 ` Geert Uytterhoeven
2012-04-12 19:52 ` Sam Ravnborg [this message]
2012-04-12 19:57 ` Andi Kleen
2012-04-12 20:07 ` Sam Ravnborg
2012-04-12 20:17 ` Geert Uytterhoeven
2012-04-12 20:35 ` Sam Ravnborg
2012-05-08 19:36 ` Geert Uytterhoeven
2012-05-12 20:23 ` Geert Uytterhoeven
2012-05-12 20:25 ` Sam Ravnborg
2012-03-30 17:16 ` [tip:x86/urgent] x86: Use -mno-avx when available tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412195248.GA30631@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®