From: Hannu Heikkinen <hannuxx@iki.fi>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: "rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>
Subject: Re: [PATCH] rtc: tegra: cleanup probe/remove routines
Date: Fri, 13 Apr 2012 15:54:05 +0300 [thread overview]
Message-ID: <20120413125405.GA5952@beyadr.localdomain> (raw)
In-Reply-To: <D958900912E20642BCBC71664EFECE3E6DD67586A0@BGMAIL02.nvidia.com>
On 13/04/12 11:05 +0530, Venu Byravarasu wrote:
> > + if (info->tegra_rtc_irq <= 0)
> > + return -EBUSY;
> Interrupt support is needed only for wake up or timer support.
> Apart from them RTC can be used for reference time keeping.
>
> So, is it not good to print a warn message as "wake up
> with alarm is not supported" and proceed further instead of
> returning failure from the driver itself?
I propose that this patch would go in as is, as this is mainly for adjusting
probe/remove routines for using devm_* funcs, and to leave that above issue
you mentioned to another patch, as it would be a change to current behavior.
br,
Hannu
next prev parent reply other threads:[~2012-04-13 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 13:40 Hannu Heikkinen
2012-04-13 5:35 ` Venu Byravarasu
2012-04-13 12:54 ` Hannu Heikkinen [this message]
2012-04-16 3:21 ` Venu Byravarasu
2012-04-13 17:01 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413125405.GA5952@beyadr.localdomain \
--to=hannuxx@iki.fi \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®