From: Felipe Balbi <balbi@ti.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
olof@lixom.net, plagnioj@jcrosoft.com,
ludovic.desroches@atmel.com, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 12/12] USB: gadget/at91_udc: add gpio_to_irq() function to vbus interrupt
Date: Mon, 16 Apr 2012 12:22:47 +0300 [thread overview]
Message-ID: <20120416092246.GH30878@arwen.pp.htv.fi> (raw)
In-Reply-To: <041833f4078b6c28cf8a286fad8982bfae18f4b8.1334567594.git.nicolas.ferre@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]
On Mon, Apr 16, 2012 at 11:20:56AM +0200, Nicolas Ferre wrote:
> Now that we are using irqdomains, we need to convert GPIO pins to Linux
> IRQ numbers using the gpio_to_irq() function.
> This call is added to request/free_irq calls.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: linux-usb@vger.kernel.org
Please carry on with your series, patches looks fine.
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/usb/gadget/at91_udc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index 0c935d7..9d7bcd9 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1863,8 +1863,8 @@ static int __devinit at91udc_probe(struct platform_device *pdev)
> mod_timer(&udc->vbus_timer,
> jiffies + VBUS_POLL_TIMEOUT);
> } else {
> - if (request_irq(udc->board.vbus_pin, at91_vbus_irq,
> - 0, driver_name, udc)) {
> + if (request_irq(gpio_to_irq(udc->board.vbus_pin),
> + at91_vbus_irq, 0, driver_name, udc)) {
> DBG("request vbus irq %d failed\n",
> udc->board.vbus_pin);
> retval = -EBUSY;
> @@ -1886,7 +1886,7 @@ static int __devinit at91udc_probe(struct platform_device *pdev)
> return 0;
> fail4:
> if (gpio_is_valid(udc->board.vbus_pin) && !udc->board.vbus_polled)
> - free_irq(udc->board.vbus_pin, udc);
> + free_irq(gpio_to_irq(udc->board.vbus_pin), udc);
> fail3:
> if (gpio_is_valid(udc->board.vbus_pin))
> gpio_free(udc->board.vbus_pin);
> @@ -1924,7 +1924,7 @@ static int __exit at91udc_remove(struct platform_device *pdev)
> device_init_wakeup(&pdev->dev, 0);
> remove_debug_file(udc);
> if (gpio_is_valid(udc->board.vbus_pin)) {
> - free_irq(udc->board.vbus_pin, udc);
> + free_irq(gpio_to_irq(udc->board.vbus_pin), udc);
> gpio_free(udc->board.vbus_pin);
> }
> free_irq(udc->udp_irq, udc);
> --
> 1.7.10
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-16 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 9:20 [PATCH 00/12] at91: 3.4-rc3 fixes Nicolas Ferre
2012-04-16 9:20 ` [PATCH 01/12] ARM: at91: Export at91_st_base Nicolas Ferre
2012-04-16 9:20 ` [PATCH 02/12] ARM: at91: Export at91_ramc_base Nicolas Ferre
2012-04-16 9:20 ` [PATCH 03/12] ARM: at91: Export at91_pmc_base Nicolas Ferre
2012-04-16 9:20 ` [PATCH 04/12] ARM: at91: Export at91_matrix_base Nicolas Ferre
2012-04-16 9:20 ` [PATCH 05/12] ARM: at91: fix typo in at91_pmc_base assembly declaration Nicolas Ferre
2012-04-16 9:20 ` [PATCH 06/12] ARM: at91: remove empty at91_init_serial function Nicolas Ferre
2012-04-16 9:20 ` [PATCH 07/12] ARM: at91: fix rm9200ek flash size Nicolas Ferre
2012-04-16 9:20 ` [PATCH 08/12] ARM: at91: fix at91sam9261ek Ethernet dm9000 irq Nicolas Ferre
2012-04-16 9:20 ` [PATCH 09/12] ARM: at91/atmel-mci: remove unused setup_dma_addr() macro Nicolas Ferre
2012-04-16 9:20 ` [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit Nicolas Ferre
2012-04-20 21:34 ` Andrew Morton
2012-04-23 8:21 ` Nicolas Ferre
2012-04-16 9:20 ` [PATCH 11/12] USB: ohci-at91: change annotations for probe/remove functions Nicolas Ferre
2012-04-17 12:41 ` Nicolas Ferre
2012-04-17 14:24 ` Alan Stern
2012-04-16 9:20 ` [PATCH 12/12] USB: gadget/at91_udc: add gpio_to_irq() function to vbus interrupt Nicolas Ferre
2012-04-16 9:22 ` Felipe Balbi [this message]
2012-04-16 10:46 ` [PATCH 13/13] dmaengine: Kconfig: fix Atmel at_hdmac entry Nicolas Ferre
2012-04-16 15:40 ` [PATCH 00/12] at91: 3.4-rc3 fixes Arnd Bergmann
2012-04-16 15:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416092246.GH30878@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®