Re: [PATCH 1/1] lpc_sch: Add Intel Centerton Multifunction Device support

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Seth,

On Wed, Mar 21, 2012 at 09:59:51AM -0700, Seth Heasley wrote:
> This patch adds the DeviceIDs for the Intel Centerton Legacy Block.  The Legacy Block includes SMBus, GPIO, and Watchdog functionality.
> 
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
> ---
>  drivers/mfd/lpc_sch.c |   16 +++++++++++++---
>  1 files changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/lpc_sch.c b/drivers/mfd/lpc_sch.c
> index abc4213..778af13 100644
> --- a/drivers/mfd/lpc_sch.c
> +++ b/drivers/mfd/lpc_sch.c
> @@ -36,10 +36,13 @@
>  
>  #define GPIOBASE	0x44
>  #define GPIO_IO_SIZE	64
> +#define GPIO_IO_SIZE_128	128
>  
>  #define WDTBASE		0x84
>  #define WDT_IO_SIZE	64
>  
> +#define PCI_DEVICE_ID_INTEL_CENTERTON_ILB	0x0c60
> +
So we're not going to need this ID anywhere else ? In the GPIO driver for
example ?
If we do need it there, this ID should move to pci_ids.h


>  static struct resource smbus_sch_resource = {
>  		.flags = IORESOURCE_IO,
>  };
> @@ -68,7 +71,7 @@ static struct resource wdt_sch_resource = {
>  
>  static struct mfd_cell tunnelcreek_cells[] = {
>  	{
> -		.name = "tunnelcreek_wdt",
> +		.name = "ie6xx_wdt",
What do we need this change for ?

The rest of the patch looks good.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/