From: Greg K H <gregkh@linuxfoundation.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Doug Thompson <norsk5@yahoo.com>
Subject: Re: [EDAC ABI v13 17/25] edac: Create a per-Memory Controller bus
Date: Mon, 16 Apr 2012 16:25:14 -0700 [thread overview]
Message-ID: <20120416232514.GA27433@kroah.com> (raw)
In-Reply-To: <1334608729-30803-18-git-send-email-mchehab@redhat.com>
On Mon, Apr 16, 2012 at 05:38:41PM -0300, Mauro Carvalho Chehab wrote:
> I'm getting this bug on machines with more than one memory controller:
>
> [ 819.094946] EDAC DEBUG: find_mci_by_dev: find_mci_by_dev()
> [ 819.094948] EDAC DEBUG: edac_create_sysfs_mci_device: edac_create_sysfs_mci_device() idx=1
> [ 819.094952] EDAC DEBUG: edac_create_sysfs_mci_device: edac_create_sysfs_mci_device(): creating device mc1
> [ 819.094967] EDAC DEBUG: edac_create_sysfs_mci_device: edac_create_sysfs_mci_device creating dimm0, located at channel 0 slot 0
> [ 819.094984] ------------[ cut here ]------------
> [ 819.100142] WARNING: at fs/sysfs/dir.c:481 sysfs_add_one+0xc1/0xf0()
> [ 819.107282] Hardware name: S2600CP
> [ 819.111078] sysfs: cannot create duplicate filename '/bus/edac/devices/dimm0'
> [ 819.119062] Modules linked in: sb_edac(+) edac_core ip6table_filter ip6_tables ebtable_nat ebtables ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack ipt_REJECT xt_CHECKSUM iptable_mangle iptable_filter ip_tables bridge stp llc sunrpc binfmt_misc dm_mirror dm_region_hash dm_log vhost_net macvtap macvlan tun kvm microcode pcspkr iTCO_wdt iTCO_vendor_support igb i2c_i801 i2c_core sg ioatdma dca sr_mod cdrom sd_mod crc_t10dif ahci libahci isci libsas libata scsi_transport_sas scsi_mod wmi dm_mod [last unloaded: scsi_wait_scan]
> [ 819.175748] Pid: 10902, comm: modprobe Not tainted 3.3.0-0.11.el7.v12.2.x86_64 #1
> [ 819.184113] Call Trace:
> [ 819.186868] [<ffffffff8105adaf>] warn_slowpath_common+0x7f/0xc0
> [ 819.193573] [<ffffffff8105aea6>] warn_slowpath_fmt+0x46/0x50
> [ 819.200000] [<ffffffff811f53d1>] sysfs_add_one+0xc1/0xf0
> [ 819.206025] [<ffffffff811f5cf5>] sysfs_do_create_link+0x135/0x220
> [ 819.212944] [<ffffffff811f7023>] ? sysfs_create_group+0x13/0x20
> [ 819.219656] [<ffffffff811f5df3>] sysfs_create_link+0x13/0x20
> [ 819.226109] [<ffffffff813b04f6>] bus_add_device+0xe6/0x1b0
> [ 819.232350] [<ffffffff813ae7cb>] device_add+0x2db/0x460
> [ 819.238300] [<ffffffffa0325634>] edac_create_dimm_object+0x84/0xf0 [edac_core]
> [ 819.246460] [<ffffffffa0325e18>] edac_create_sysfs_mci_device+0xe8/0x290 [edac_core]
> [ 819.255215] [<ffffffffa0322e2a>] edac_mc_add_mc+0x5a/0x2c0 [edac_core]
> [ 819.262611] [<ffffffffa03412df>] sbridge_register_mci+0x1bc/0x279 [sb_edac]
> [ 819.270493] [<ffffffffa03417a3>] sbridge_probe+0xef/0x175 [sb_edac]
> [ 819.277630] [<ffffffff813ba4e8>] ? pm_runtime_enable+0x58/0x90
> [ 819.284268] [<ffffffff812f430c>] local_pci_probe+0x5c/0xd0
> [ 819.290508] [<ffffffff812f5ba1>] __pci_device_probe+0xf1/0x100
> [ 819.297117] [<ffffffff812f5bea>] pci_device_probe+0x3a/0x60
> [ 819.303457] [<ffffffff813b1003>] really_probe+0x73/0x270
> [ 819.309496] [<ffffffff813b138e>] driver_probe_device+0x4e/0xb0
> [ 819.316104] [<ffffffff813b149b>] __driver_attach+0xab/0xb0
> [ 819.322337] [<ffffffff813b13f0>] ? driver_probe_device+0xb0/0xb0
> [ 819.329151] [<ffffffff813af5d6>] bus_for_each_dev+0x56/0x90
> [ 819.335489] [<ffffffff813b0d7e>] driver_attach+0x1e/0x20
> [ 819.341534] [<ffffffff813b0980>] bus_add_driver+0x1b0/0x2a0
> [ 819.347884] [<ffffffffa0347000>] ? 0xffffffffa0346fff
> [ 819.353641] [<ffffffff813b19f6>] driver_register+0x76/0x140
> [ 819.359980] [<ffffffff8159f18b>] ? printk+0x51/0x53
> [ 819.365524] [<ffffffffa0347000>] ? 0xffffffffa0346fff
> [ 819.371291] [<ffffffff812f5896>] __pci_register_driver+0x56/0xd0
> [ 819.378096] [<ffffffffa0347054>] sbridge_init+0x54/0x1000 [sb_edac]
> [ 819.385231] [<ffffffff8100203f>] do_one_initcall+0x3f/0x170
> [ 819.391577] [<ffffffff810bcd2e>] sys_init_module+0xbe/0x230
> [ 819.397926] [<ffffffff815bb529>] system_call_fastpath+0x16/0x1b
> [ 819.404633] ---[ end trace 1654fdd39556689f ]---
>
> This is happening because the bus is not being properly initialized.
> Instead of putting the memory sub-devices inside the memory controller,
> it is putting everything under the same directory:
>
> $ tree /sys/bus/edac/
> /sys/bus/edac/
> ├── devices
> │ ├── all_channel_counts -> ../../../devices/system/edac/mc/mc0/all_channel_counts
> │ ├── csrow0 -> ../../../devices/system/edac/mc/mc0/csrow0
> │ ├── csrow1 -> ../../../devices/system/edac/mc/mc0/csrow1
> │ ├── csrow2 -> ../../../devices/system/edac/mc/mc0/csrow2
> │ ├── dimm0 -> ../../../devices/system/edac/mc/mc0/dimm0
> │ ├── dimm1 -> ../../../devices/system/edac/mc/mc0/dimm1
> │ ├── dimm3 -> ../../../devices/system/edac/mc/mc0/dimm3
> │ ├── dimm6 -> ../../../devices/system/edac/mc/mc0/dimm6
> │ ├── inject_addrmatch -> ../../../devices/system/edac/mc/mc0/inject_addrmatch
> │ ├── mc -> ../../../devices/system/edac/mc
> │ └── mc0 -> ../../../devices/system/edac/mc/mc0
> ├── drivers
> ├── drivers_autoprobe
> ├── drivers_probe
> └── uevent
>
> On a multi-memory controller system, the names "csrow%d" and "dimm%d"
> should be under "mc%d", and not at the main hierarchy level.
>
> So, we need to create a per-MC bus, in order to have its own namespace.
>
> Reviewed-by: Aristeu Rozanski <arozansk@redhat.com>
> Cc: Doug Thompson <norsk5@yahoo.com>
> Cc: Greg K H <gregkh@linuxfoundation.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2012-04-16 23:25 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 20:38 [EDAC ABI v13 00/25] Fix EDAC userspace ABI Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 01/25] edac: Initialize the dimm label with the known information Mauro Carvalho Chehab
2012-05-07 15:52 ` Borislav Petkov
2012-05-14 12:48 ` Borislav Petkov
2012-05-14 13:47 ` Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 02/25] edac: Cleanup the logs for i7core and sb edac drivers Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 03/25] i5400_edac: improve debug messages to better represent the filled memory Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 04/25] events/hw_event: Create a Hardware Events Report Mecanism (HERM) Mauro Carvalho Chehab
2012-05-09 12:13 ` Borislav Petkov
2012-05-09 12:50 ` Mauro Carvalho Chehab
2012-05-09 13:22 ` Borislav Petkov
2012-05-09 13:51 ` Mauro Carvalho Chehab
2012-05-09 14:06 ` Borislav Petkov
2012-05-09 14:15 ` Mauro Carvalho Chehab
2012-05-09 14:24 ` Borislav Petkov
2012-05-10 13:16 ` Mauro Carvalho Chehab
2012-05-10 13:41 ` Borislav Petkov
2012-05-10 14:53 ` Mauro Carvalho Chehab
2012-05-10 15:02 ` Borislav Petkov
2012-05-10 15:08 ` Mauro Carvalho Chehab
2012-05-10 15:12 ` Borislav Petkov
2012-05-10 15:16 ` Mauro Carvalho Chehab
2012-05-10 19:57 ` [PATCH] edac: Increase version to 3.0.0 (aka: "HERM" version) Mauro Carvalho Chehab
2012-05-11 10:08 ` Borislav Petkov
2012-05-10 15:20 ` [EDAC ABI v13 04/25] events/hw_event: Create a Hardware Events Report Mecanism (HERM) Steven Rostedt
2012-05-10 15:27 ` Borislav Petkov
2012-05-10 15:34 ` Mauro Carvalho Chehab
2012-05-09 14:19 ` Steven Rostedt
2012-05-10 13:17 ` Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 05/25] i5000_edac: Fix the logic that retrieves memory information Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 06/25] e752x_edac: provide more info about how DIMMS/ranks are mapped Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 07/25] edac: Rename the parent dev to pdev Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 08/25] edac: use Documentation-nano format for some data structs Mauro Carvalho Chehab
2012-05-09 12:23 ` Borislav Petkov
2012-05-09 12:55 ` Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 09/25] edac: rewrite the sysfs code to use struct device Mauro Carvalho Chehab
2012-05-09 12:34 ` Borislav Petkov
2012-05-09 13:10 ` Mauro Carvalho Chehab
2012-05-09 13:24 ` Borislav Petkov
2012-05-09 14:09 ` [PATCH v21] edac: rewrite the sysfs code to use struct device - Was: " Mauro Carvalho Chehab
2012-05-09 13:13 ` Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 10/25] mpc85xx_edac: convert sysfs logic " Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 11/25] amd64_edac: " Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 12/25] i7core_edac: convert it " Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 13/25] edac: Get rid of the old kobj's from the edac mc code Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 14/25] edac: add a new per-dimm API and make the old per-virtual-rank API obsolete Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 15/25] edac: add a sysfs node to report the maximum location for the system Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 16/25] edac: Add debufs nodes to allow doing fake error inject Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 17/25] edac: Create a per-Memory Controller bus Mauro Carvalho Chehab
2012-04-16 23:25 ` Greg K H [this message]
2012-04-16 20:38 ` [EDAC ABI v13 18/25] edac: Move grain/dtype/edac_type calculus to be out of channel loop Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 19/25] i82975x_edac: Test nr_pages earlier to save a few CPU cycles Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 20/25] i5100_edac: Fix a warning when compiled with 32 bits Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 21/25] i7300_edac: Get rid of some wrongly-solved rebase conflict Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 22/25] edac: Only expose csrows/channels on legacy API if they're populated Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 23/25] edac: Fix a typo at edac_mc_sysfs Mauro Carvalho Chehab
2012-04-16 20:38 ` [EDAC ABI v13 24/25] edac: change the mem allocation scheme to make Documentation/kobject.txt happy Mauro Carvalho Chehab
2012-04-17 21:17 ` Joe Perches
2012-04-19 13:14 ` Mauro Carvalho Chehab
2012-04-22 6:37 ` Joe Perches
2012-04-19 13:21 ` [PATCH] " Mauro Carvalho Chehab
2012-04-19 15:28 ` Greg K H
2012-04-16 20:38 ` [EDAC ABI v13 25/25] i7core_edac: " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416232514.GA27433@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=norsk5@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome