From: David Miller <davem@davemloft.net>
To: laura@rosedu.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
eric.dumazet@gmail.com, nhorman@tuxdriver.com
Subject: Re: [PATCH] ethernet: fix checkpatch errors
Date: Tue, 17 Apr 2012 22:50:18 -0400 (EDT) [thread overview]
Message-ID: <20120417.225018.2141913804796063004.davem@davemloft.net> (raw)
In-Reply-To: <1334672844-10129-1-git-send-email-laura@rosedu.org>
From: Laura Vasilescu <laura@rosedu.org>
Date: Tue, 17 Apr 2012 17:27:24 +0300
> Signed-off-by: Laura Vasilescu <laura@rosedu.org>
I'd rather have the checkpath errors than what we end up with
your changes:
> - else if (1 /*dev->flags&IFF_PROMISC */ ) {
> - if (unlikely(compare_ether_addr_64bits(eth->h_dest, dev->dev_addr)))
> + else if (1 /*dev->flags&IFF_PROMISC */) {
> + if (unlikely(compare_ether_addr_64bits(eth->h_dest,
> + dev->dev_addr)))
This indentation is wrong, the "dev->dev_addr" argument must line up
with the first column after the openning parenthesis on the previous
line.
> -int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type)
> +int eth_header_cache(const struct neighbour *neigh,
> + struct hh_cache *hh,
> + __be16 type)
Same problem here for hh and type args.
next prev parent reply other threads:[~2012-04-18 2:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:27 Laura Vasilescu
2012-04-18 2:50 ` David Miller [this message]
2012-04-18 6:34 ` Laura Vasilescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417.225018.2141913804796063004.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=laura@rosedu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®