From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
srinivas.bakki@nxp.com, stern@rowland.harvard.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] USB: Add driver for NXP ISP1301 USB transceiver
Date: Tue, 17 Apr 2012 13:40:06 +0000 [thread overview]
Message-ID: <201204171340.06788.arnd@arndb.de> (raw)
In-Reply-To: <1334666424-2277-1-git-send-email-stigge@antcom.de>
On Tuesday 17 April 2012, Roland Stigge wrote:
> +static int match(struct device *dev, void *data)
> +{
> + struct device_node *node = (struct device_node *)data;
> + return dev->of_node == node ? 1 : 0;
> +}
One small correction: you should probably check if the device
is actually bound to isp1301_driver:
return (dev->of_node == node) && (dev->driver == &isp1301_driver.driver);
Otherwise, the changes from last version look all good.
Arnd
prev parent reply other threads:[~2012-04-17 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 12:40 Roland Stigge
2012-04-17 12:40 ` [PATCH v3 2/3] USB: gadget driver for LPC32xx Roland Stigge
2012-04-17 12:40 ` [PATCH v3 3/3] USB: ohci-nxp: Use isp1301 driver Roland Stigge
2012-04-17 13:40 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204171340.06788.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
--cc=stern@rowland.harvard.edu \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®