From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752850Ab2DQVHP (ORCPT ); Tue, 17 Apr 2012 17:07:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018Ab2DQVHO (ORCPT ); Tue, 17 Apr 2012 17:07:14 -0400 Date: Tue, 17 Apr 2012 17:07:00 -0400 From: Josh Boyer To: Ben Hutchings Cc: Matt Carlson , Michael Chan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: tg3 'No PHY devices' loading issue Message-ID: <20120417210700.GJ19507@zod.bos.redhat.com> References: <20120417141856.GA19507@zod.bos.redhat.com> <20120417185007.GA3742@mcarlson.broadcom.com> <20120417191042.GB3932@decadent.org.uk> <20120417194029.GH19507@zod.bos.redhat.com> <20120417205955.GC3932@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120417205955.GC3932@decadent.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 17, 2012 at 09:59:55PM +0100, Ben Hutchings wrote: > On Tue, Apr 17, 2012 at 03:40:30PM -0400, Josh Boyer wrote: > > On Tue, Apr 17, 2012 at 08:10:42PM +0100, Ben Hutchings wrote: > > > On Tue, Apr 17, 2012 at 11:50:07AM -0700, Matt Carlson wrote: > > > > On Tue, Apr 17, 2012 at 10:18:57AM -0400, Josh Boyer wrote: > > > > > Hi Matt and Michael, > > > > > > > > > > I'm seeing an odd issue with the tg3 driver on one of my development > > > > > machines. I've tried kernels 3.2.10, 3.3.0, 3.3.1, 3.3.2 and 3.4-rc3 > > > > > and they all seem to exhibit this issue now. When the machine boots > > > > > and the tg3 driver is loaded, it fails to find a PHY and then reports > > > > > 'Problem fetching invariants of chip'. If I do a rmmod/modprobe of > > > > > tg3 after login, the probe seems to work fine and ethernet works as > > > > > expected. You can see this in the dmesg below: > > > [...] > > > > The 57788 uses the broadcom phylib module. For some reason, it isn't > > > > available the first module load attempt. A while ago, code was added to > > > > phylib to request modules from userspace if the particular phy support > > > > code wasn't already loaded. It looks like this mechanism isn't working > > > > too well the first time through. > > > [...] > > > > > > At a guess, tg3 is in the initramfs but broadcom isn't. > > > > Good guess. At least on one of the initramfs' I checked. I'll verify > > the others, but it seems likely they match. As I just said in my other > > reply, I would have expected tg3 to have a module dep on it to get it > > included in the initramfs built, but it seems that isn't the case. > > tg3 doesn't use any symbols from broadcom, which is the only way > depmod can find dependencies. > > In initramfs-tools (used in Debian and its derivatives) we just copy > all PHY drivers into the initramfs by default. dracut should probably > do the same, at least when phylib is in the initramfs (or built into > the kernel). (tg3 does use symbols from phylib.) Heh. Yep, that's basically what I just concluded as well in my other reply. I'll work with Harald and get that included or something similar to it. josh