From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000Ab2DQUQL (ORCPT ); Tue, 17 Apr 2012 16:16:11 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:48956 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542Ab2DQUQK (ORCPT ); Tue, 17 Apr 2012 16:16:10 -0400 From: "Rafael J. Wysocki" To: huang ying Subject: Re: [RFC PATCH] PCIe: Add PCIe runtime D3cold support Date: Tue, 17 Apr 2012 22:20:45 +0200 User-Agent: KMail/1.13.6 (Linux/3.4.0-rc3+; KDE/4.6.0; x86_64; ; ) Cc: "Yan, Zheng" , bhelgaas@google.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Lin Ming , Zhang Rui , ACPI Devel Mailing List References: <4F8790F6.5080408@intel.com> <201204161907.13806.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201204172220.45970.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, April 17, 2012, huang ying wrote: > On Tue, Apr 17, 2012 at 1:07 AM, Rafael J. Wysocki wrote: > > Moreover, I really don't think it's a good idea to put PCI Express ports into > > low-power states in general. It might work on your platform, whatever it is, > > but that doesn't mean it's going to work on every PCI Express system out > > there. I actually know of a number of such systems where it surely won't > > work at all. > > The runtime PM support for PCIe port is not turned on by default, we need > > # echo auto > /sys/devices/pcixxxx:xx//power/control > > to turn on it. And we will turn on it on system it works. Is this sufficient? No, it is not. In some cases it shouldn't be enabled at all for PCI Express ports, as far as I can say, so to be on the safe side we should only enable it on platforms where PCI Express ports are known to work correctly with runtime PM. Thanks, Rafael