Re: [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver

[Dong Aisheng <aisheng.dong@freescale.com>]

On Wed, Apr 18, 2012 at 04:12:50AM +0800, Stephen Warren wrote:
> On 04/13/2012 10:18 AM, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@linaro.org>
> > 
> > Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
> 
> > diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> 
> >  static const struct of_device_id imx_pmx_dt_ids[] = {
> > +#ifdef CONFIG_PINCTRL_IMX6Q
> > +	{ .compatible = "fsl,imx6q-iomuxc", .data = (void *) &imx6q_pinctrl_info, },
> > +#endif
> >  	{ /* sentinel */ }
> >  };
> >  MODULE_DEVICE_TABLE(of, imx_pmx_dt_ids);
> 
> Sorry for the slow review.
> 
> Based on SPEAr pinctrl review comments, we shouldn't have a single
> driver that knows about all the different SoCs that it could support,
> but rather one driver per SoC, with each of those calling into some
> utility code in the core driver to do all the probe/remove work.
> 
Sound like a good idea.

> For more details, see commit a4c0738 "pinctrl: tegra: refactor probe
> handling" in
> git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
> (in branch for-3.5/gpio-pinmux).
> 
I will check it.
Thanks for the reminder.

Regards
Dong Aisheng