From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Andres Salomon <dilinger@queued.net>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Chris Ball <cjb@laptop.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Valentin Rothberg <valentinrothberg@googlemail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: olpc_dcon.c: checkpatch.pl and style fixups
Date: Wed, 18 Apr 2012 16:30:04 -0700 [thread overview]
Message-ID: <20120418233004.GB9419@kroah.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1204150049270.15578@swampdragon.chaosbits.net>
On Sun, Apr 15, 2012 at 12:53:04AM +0200, Jesper Juhl wrote:
> This patch removes the few checkpatch.pl issues that are currently
> reported for this file.
>
> It makes these changes:
>
> 1. Quoted strings that were broken over multiple lines are put on a
> single line for easier grep'ability.
Woah, no, a patch should only do one single thing.
If you have to list what it does, you are not doing it correctly.
And, as this patch shows, people liked part of it, but not others, so
you had to redo it. If you had split this up into individual patches, I
could have just accepted those and not the others.
So please, always break your patches up into the proper pieces.
greg k-h
prev parent reply other threads:[~2012-04-18 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 22:53 Jesper Juhl
2012-04-15 2:26 ` Andres Salomon
2012-04-15 5:13 ` Jordan Crouse
2012-04-15 21:39 ` Jesper Juhl
2012-04-15 22:07 ` Andres Salomon
2012-04-18 23:30 ` Greg Kroah-Hartman
2012-04-18 23:39 ` Jesper Juhl
2012-04-18 23:30 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418233004.GB9419@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cjb@laptop.org \
--cc=devel@driverdev.osuosl.org \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=jj@chaosbits.net \
--cc=jon.nettleton@gmail.com \
--cc=jordan@cosmicpenguin.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=valentinrothberg@googlemail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®