From: Mika Westerberg <mika.westerberg@iki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Hannu Heikkinen <hannuxx@iki.fi>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi/ep93xx: clean probe/remove routines
Date: Thu, 19 Apr 2012 09:19:53 +0300 [thread overview]
Message-ID: <20120419061953.GD18520@mwesterb-mobl.lan> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F00206987A41FD@AUSP01VMBX24.collaborationhost.net>
On Wed, Apr 18, 2012 at 11:09:18AM -0500, H Hartley Sweeten wrote:
> But, I really don't think we actually gain anything by displaying the
> memory and irq. Maybe this would be more useful:
>
> dev_info(&pdev->dev, "EP93xx SPI Controller using %s\n",
> espi->dma_tx ? "DMA" : "PIO");
>
> That way the user knows at boot time if the spi controller is using DMA or PIO.
>
> Mika, what do you think?
I agree, having the driver to print whether DMA or PIO is used brings more
value than it is currently doing. However, that is a subject of a separate
patch not this one.
next prev parent reply other threads:[~2012-04-19 6:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 12:36 Hannu Heikkinen
2012-04-18 16:09 ` H Hartley Sweeten
2012-04-19 6:19 ` Mika Westerberg [this message]
2012-04-19 6:16 ` Mika Westerberg
2012-04-19 6:39 ` Hannu Heikkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419061953.GD18520@mwesterb-mobl.lan \
--to=mika.westerberg@iki.fi \
--cc=hannuxx@iki.fi \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®