From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511Ab2DSGkp (ORCPT ); Thu, 19 Apr 2012 02:40:45 -0400 Received: from relay.sigmatic.fi ([80.69.161.51]:41182 "EHLO relay.sigmatic.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab2DSGko (ORCPT ); Thu, 19 Apr 2012 02:40:44 -0400 Date: Thu, 19 Apr 2012 09:39:22 +0300 From: Hannu Heikkinen To: Mika Westerberg Cc: spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca Subject: Re: [PATCH] spi/ep93xx: clean probe/remove routines Message-ID: <20120419063922.GA3437@beyadr.localdomain> References: <1334752571-24627-1-git-send-email-hannuxx@iki.fi> <20120419061609.GC18520@mwesterb-mobl.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120419061609.GC18520@mwesterb-mobl.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/12 09:16 +0300, Mika Westerberg wrote: > On Wed, Apr 18, 2012 at 03:36:11PM +0300, Hannu Heikkinen wrote: > > Use devm_* functions for managing devres resources. > > > > Also use local espi_irq and remove irq variable from > > struct ep93xx_spi. > > > > Cc: mika.westerberg@iki.fi > > Cc: grant.likely@secretlab.ca > > Signed-off-by: Hannu Heikkinen > > --- > > drivers/spi/spi-ep93xx.c | 36 ++++++++++-------------------------- > > 1 file changed, 10 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c > > index 6db2887..2c5fb81 100644 > > --- a/drivers/spi/spi-ep93xx.c > > +++ b/drivers/spi/spi-ep93xx.c > > @@ -114,7 +114,6 @@ struct ep93xx_spi { > > struct clk *clk; > > void __iomem *regs_base; > > unsigned long sspdr_phys; > > - int irq; > > unsigned long min_rate; > > unsigned long max_rate; > > bool running; > > @@ -1035,6 +1034,7 @@ static int __devinit ep93xx_spi_probe(struct platform_device *pdev) > > struct ep93xx_spi_info *info; > > struct ep93xx_spi *espi; > > struct resource *res; > > + int espi_irq; > > Since you are going to make a new version of the patch anyway, can you rename > 'espi_irq' to just plain 'irq'? Will do. > After that you can add my > > Acked-by: Mika Westerberg I will do the changes needed addressed by you and Hartley. Thanks, Hannu