From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541Ab2DSUjf (ORCPT ); Thu, 19 Apr 2012 16:39:35 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:49178 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932281Ab2DSUje (ORCPT ); Thu, 19 Apr 2012 16:39:34 -0400 Date: Thu, 19 Apr 2012 22:39:15 +0200 From: Wolfram Sang To: Roland Stigge Cc: Grant Likely , Rob Herring , vitalywool@gmail.com, khali@linux-fr.org, ben-linux@fluff.org, rob.herring@calxeda.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, arm@kernel.org, linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com Subject: Re: [PATCH v4] i2c: Add device tree support to i2c-pnx.c Message-ID: <20120419203915.GB28005@pengutronix.de> References: <1334850612-24151-1-git-send-email-stigge@antcom.de> <20120419160715.GD24987@pengutronix.de> <4F903E0C.6010604@antcom.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: <4F903E0C.6010604@antcom.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: wsa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 19, 2012 at 06:32:12PM +0200, Roland Stigge wrote: > Hi, >=20 > On 04/19/2012 06:07 PM, Wolfram Sang wrote: > >> + - clock-frequency: desired I2C bus clock frequency in Hz, > >> Default: 100000 Hz + - pnx,timeout: I2C bus timeout in > >> milliseconds, Default: 10 ms > >=20 > > I'd like to repeat my question to the devicetree folks here: Can we > > have timeout generic? It doesn't make sense to me to have that per > > vendor again and again. >=20 > Sounds completely reasonable. >=20 > To help make the devicetree conversion into 3.5, I would prefer to > integrate the "vendor,timeout" as-is if a longish standardization > process would block this, considering that we luckily only have 2-3 of > such timeout definitions currently. The "blocking" argument will be true for most dt-conversions. Only thing that might change is that the argument will then be "we already have 9-10 of such timeouts, so we can have another one" ;) I've been there before, if you make one exception once, other people will nail you on that. I'd like to avoid that. Let's just hope we can agree on "timeout" quickly and all will be fine. > I'd volunteer to clean up later by preparing a patch when there is a > standard timeout defined. The problem with bindings is that you must support them forever once introduced. Old device-trees should still work with newer kernels. =20 > If we have a solution soon, I will prepare a new version of the patch, > of course, in the next days. Thanks. One question, though: Will it really block dt-conversion? The whole conversion should not be depending on the i2c-driver? > > Did you change this, too? Timeouts are better readable in dec :) >=20 > Right. But even when removing the "0x" in the timeout line above, it's > still hex, see Documentation/devicetree/booting-without-of.txt >=20 > Or did I get sth. wrong? I think the document is probably outdated :( "clock-frequency" is also without 0x and dec. Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --neYutvxvOLaeuPCA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+Qd/MACgkQD27XaX1/VRv68wCfSlP1dTj/oNt9iMmleHyCHsL6 crMAnjv0xGzqCNgsyufi6nkcftUxbfpm =16eA -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--