From: Mike Frysinger <vapier@gentoo.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org,
Sonic Zhang <sonic.zhang@analog.com>, Bob Liu <lliubbo@gmail.com>
Subject: Re: [PATCH] blackfin: fix ifdef fustercluck in mach-bf538/boards/ezkit.c
Date: Fri, 20 Apr 2012 00:08:34 -0400 [thread overview]
Message-ID: <201204200008.36915.vapier@gentoo.org> (raw)
In-Reply-To: <1334807838-3006-1-git-send-email-paul.gortmaker@windriver.com>
[-- Attachment #1: Type: Text/Plain, Size: 766 bytes --]
On Wednesday 18 April 2012 23:57:18 Paul Gortmaker wrote:
> This file has lots and lots of ifdef, around structure decls
> and structure usages.
yeah. we killed some off, and there probably is room for more, but some of the
subsystems are not friendly to dynamic resource management, so we need some of
the ifdefs. SPI doesn't like it if you declare resources for different devices
on the same CS even if you never actually use the device in question. be nice
if the detection could be delayed until "open" time.
> but since I had to tag the #endif with their respective #ifdef
> options to find this misplaced SPI endif, it would be silly to
> then go and delete them all. So they stay.
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-20 4:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 3:57 Paul Gortmaker
2012-04-20 4:08 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204200008.36915.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lliubbo@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®