From: Wolfram Sang <w.sang@pengutronix.de>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>, Feng Tang <feng.tang@intel.com>,
Alexander Stein <alexander.stein@systec-electronic.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH 1/2] i2c-eg20t: add helper function for xfer check
Date: Fri, 20 Apr 2012 22:39:37 +0200 [thread overview]
Message-ID: <20120420203937.GB12691@pengutronix.de> (raw)
In-Reply-To: <1334817485-7121-1-git-send-email-tomoya.rohm@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Thu, Apr 19, 2012 at 03:38:04PM +0900, Tomoya MORINAGA wrote:
> Currently, there are the same code for xfer complete check processing.
> So, I add helper function pch_i2c_wait_for_check_xfer.
>
> Reported-by: Wolfram Sang <w.sang@pengutronix.de>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Both applied to next, thanks for doing this! ~120 lines saved, that's
about 10%. And also way better maintainable, yay.
My checkers found some other issues, for which I will send patches in a
minute. Please have a look and test.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-04-20 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 6:38 Tomoya MORINAGA
2012-04-19 6:38 ` [PATCH 2/2] i2c-eg20t: Merge 2 functions Tomoya MORINAGA
2012-04-20 20:39 ` Wolfram Sang [this message]
2012-04-23 4:25 ` [PATCH 1/2] i2c-eg20t: add helper function for xfer check Tomoya MORINAGA
2012-04-26 2:59 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420203937.GB12691@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=alexander.stein@systec-electronic.com \
--cc=ben-linux@fluff.org \
--cc=feng.tang@intel.com \
--cc=joel.clark@intel.com \
--cc=khali@linux-fr.org \
--cc=kok.howg.ewe@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya.rohm@gmail.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®