From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082Ab2DUGVi (ORCPT ); Sat, 21 Apr 2012 02:21:38 -0400 Received: from mail-pz0-f52.google.com ([209.85.210.52]:53148 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981Ab2DUGVh (ORCPT ); Sat, 21 Apr 2012 02:21:37 -0400 Date: Fri, 20 Apr 2012 23:21:30 -0700 From: Dmitry Torokhov To: Daniel Kurtz Cc: Che-Liang Chiou , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH 0/5] Input: serio_raw - add monitor/replay debugging interface Message-ID: <20120421062130.GC27551@core.coreip.homeip.net> References: <1328084386-31110-1-git-send-email-clchiou@chromium.org> <1328671497-20880-1-git-send-email-clchiou@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2012 at 11:18:38AM +0800, Daniel Kurtz wrote: > On Wed, Feb 8, 2012 at 11:24 AM, Che-Liang Chiou wrote: > > > > The serio_raw driver is designed to provide "raw access" to mice, keyboards > > etc; thus, a driver accessing serio_raw may live entirely in userland. > > > > However, serio_raw lacks testability.  It is practically impossible to do > > regression tests on changes to a serio_raw -based userland driver.  On the other > > hand, the kernel's input subsystem has good testability support.  With the help > > of tools like utouch-evemu, we may capture and replay input events for evdev > > drivers in regression tests. > > > > This patchset contains extensions to the serio_raw driver which add debugfs > > entries for monitoring and replaying byte sequence between a userland driver > > and device.  These byte sequences can be used in regression tests of the > > userland driver.  This patchset closes the gap between serio_raw and the input > > subsystem regarding testability. > > > > This patchset is successfully applied on kernel version 3.3-rc2. > > > > Che-Liang Chiou (5): > >  Input: serio_raw - return proper result when serio_raw_read fails > >  Input: serio_raw - extract queue interface > >  Input: serio_raw - factor out common pattern of write > >  Input: serio_raw - add debugfs interface > >  Input: serio_raw - implement debugfs interface > > For patches 3-5: > Reviewed-by: Daniel Kurtz > > For patch 1 (and its implication on queue_read() in patch 2, I'd > prefer to hear feedback from the list. I have already taken the patch 1, but I am unsure why we need kernel support for the monitor and replay. It seems you should only need a userspace program that would sit between the driver being tested and serio_raw misc device and pipe data back and forth, optionally saving it for subsequent replay. Thanks. -- Dmitry