mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: sameo@linux.intel.com, m.grzeschik@pengutronix.de,
	randy.dunlap@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch] Touch: DA9052/53 touch screen driver v2
Date: Fri, 20 Apr 2012 23:38:55 -0700	[thread overview]
Message-ID: <20120421063855.GA2360@core.coreip.homeip.net> (raw)
In-Reply-To: <1334924925.3752.14.camel@dhruva>

Hi Ashish,

On Fri, Apr 20, 2012 at 05:58:45PM +0530, Ashish Jangam wrote:
> +static irqreturn_t da9052_ts_pendwn_irq(int irq, void *data)
> +{
> +	struct da9052_tsi *tsi = data;
> +
> +	if (!tsi->stopped) {
> +		/* Mask PEN_DOWN event and unmask TSI_READY event */
> +		disable_irq_nosync(tsi->da9052->irq_base + tsi->irq_pendwn);
> +		enable_irq(tsi->da9052->irq_base + tsi->irq_datardy);

Why did you switch to using irq_base here? da9052_onkey driver does not
do that, should it?

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-04-21  6:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 12:28 Ashish Jangam
2012-04-21  6:38 ` Dmitry Torokhov [this message]
2012-04-24 13:48   ` Ashish Jangam
2012-04-27 12:46   ` Ashish Jangam
2012-04-30  6:41     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120421063855.GA2360@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=ashish.jangam@kpitcummins.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=randy.dunlap@oracle.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®