From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751624Ab2DULs1 (ORCPT ); Sat, 21 Apr 2012 07:48:27 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:45087 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354Ab2DULs0 (ORCPT ); Sat, 21 Apr 2012 07:48:26 -0400 Date: Sat, 21 Apr 2012 12:48:03 +0100 From: Russell King - ARM Linux To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Alexander Shiyan , linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/17] ARM clps711x: Added Cirrus Logic EP7312 CPU variant Message-ID: <20120421114803.GE24211@n2100.arm.linux.org.uk> References: <1334999490-27177-1-git-send-email-shc_work@mail.ru> <1334999490-27177-3-git-send-email-shc_work@mail.ru> <201204211121.49610.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201204211121.49610.arnd@arndb.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 21, 2012 at 11:21:49AM +0000, Arnd Bergmann wrote: > On Saturday 21 April 2012, Alexander Shiyan wrote: > > > > Added register definitions specific to EP7312 and the necessary > > configuration options. > > > > Signed-off-by: Alexander Shiyan > > --- > > arch/arm/include/asm/hardware/ep7312.h | 106 ++++++++++++++++++++++++ > > arch/arm/mach-clps711x/Kconfig | 9 ++- > > arch/arm/mach-clps711x/include/mach/hardware.h | 4 + > > drivers/net/irda/Kconfig | 3 +- > > 4 files changed, 119 insertions(+), 3 deletions(-) > > create mode 100644 arch/arm/include/asm/hardware/ep7312.h > > I'm missing some historical background here. Why are these files in asm/hardware > rather than in mach/? Should we move them to the platform directory? That's where we used to put truely hardware dependent stuff, rather than machine type stuff when the structure was first implemented. At that time we had a number of different mach-* directories wanting to share things like the acorn IOC/IOMD stuff, and there's also sharing of definitions between CLPS711x and EP93xx. That was long before we invented the plat-* stuff - but even that doesn't actually cover what asm/hardware does - eg, the SA1111 stuff shared between SA11x0 and PXA.