From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ulrich Drepper <drepper@akkadia.org>
Cc: a.p.zijlstra@chello.nl, dsahern@gmail.com, eranian@google.com,
linux-kernel@vger.kernel.org, mingo@redhat.com, paulus@samba.org,
robert.richter@amd.com
Subject: Re: [PATCH] Small perf cleanup
Date: Mon, 23 Apr 2012 15:39:01 -0300 [thread overview]
Message-ID: <20120423183901.GA15385@infradead.org> (raw)
In-Reply-To: <201204231304.q3ND4TFe020805@drepperk.user.openhosting.com>
Em Mon, Apr 23, 2012 at 09:04:29AM -0400, Ulrich Drepper escreveu:
> I just noticed this. The if branch is completely unnecessary since
> 'realloc' handles NULL pointers for the first parameter. This is
> really only a cleanup and submitted mainly to prevent proliferation
> of bad practices.
Thanks, applied to my perf/core branch at:
http://git.kernel.org/?p=linux/kernel/git/acme/linux.git;a=shortlog;h=refs/heads/perf/core
- Arnaldo
next prev parent reply other threads:[~2012-04-23 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 13:04 Ulrich Drepper
2012-04-23 18:39 ` Arnaldo Carvalho de Melo [this message]
2012-05-11 6:25 ` [tip:perf/core] perf tools: Cleanup realloc use tip-bot for Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423183901.GA15385@infradead.org \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=drepper@akkadia.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®