From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753815Ab2DXMeK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Apr 2012 08:34:10 -0400
Received: from na3sys009aog135.obsmtp.com ([74.125.149.84]:60337 "EHLO
	na3sys009aog135.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753586Ab2DXMeI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Apr 2012 08:34:08 -0400
Date: Tue, 24 Apr 2012 15:32:52 +0300
From: Felipe Balbi <balbi@ti.com>
To: Hiroshi DOYU <hdoyu@nvidia.com>
Cc: linux-tegra@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
        Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Russell King <linux@arm.linux.org.uk>,
        Tony Lindgren <tony@atomide.com>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Jamie Iles <jamie@jamieiles.com>,
        Rob Herring <rob.herring@calxeda.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: tegra: Add SMMU enabler in AHB
Message-ID: <20120424123248.GG8444@arwen.pp.htv.fi>
Reply-To: balbi@ti.com
References: <1335269116-9578-1-git-send-email-hdoyu@nvidia.com>
 <1335269116-9578-2-git-send-email-hdoyu@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="J3rqiH0DIeiRD2zz"
Content-Disposition: inline
In-Reply-To: <1335269116-9578-2-git-send-email-hdoyu@nvidia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--J3rqiH0DIeiRD2zz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Apr 24, 2012 at 03:05:15PM +0300, Hiroshi DOYU wrote:
> @@ -95,6 +98,21 @@ static inline void gizmo_writel(unsigned long value, u=
nsigned long offset)
>  	writel(value, tegra_ahb->regs + offset);
>  }
> =20
> +#ifdef CONFIG_ARCH_TEGRA_3x_SOC
> +
> +void tegra_ahb_enable_smmu(void)
> +{
> +	unsigned long val;
> +
> +	val =3D gizmo_readl(AHB_ARBITRATION_XBAR_CTRL);
> +	val |=3D AHB_ARBITRATION_XBAR_CTRL_SMMU_INIT_DONE_DONE <<
> +		AHB_ARBITRATION_XBAR_CTRL_SMMU_INIT_DONE_SHIFT;
> +	gizmo_writel(val, AHB_ARBITRATION_XBAR_CTRL);
> +}
> +EXPORT_SYMBOL(tegra_ahb_enable_smmu);

ok, so this is the only place where you need that global pointer. Who
would call this ? Can you do runtime detection of the SoC and enable
SMMU based on that ?

I mean, will this function always be called for TEGRA 3 SoCs or is there
another condition to that ?

--=20
balbi

--J3rqiH0DIeiRD2zz
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJPlp1wAAoJEIaOsuA1yqREm7QP/2hqstAY6K8zz6WsdgQkB9/r
HIAUlH7WKJ7LVHGC1fAIBa1A4okL3fS9bebTCGp9cfertmUM3KGY/7MV4mJM+vKP
YdoebyEz+ENXYHgt9KSNOErPuKKCJaU58/g8Zz0Q0iHCtsz8/zUvWSSCBZepIADL
MLz7pgpxAwsOVJmV7OpmGHFb9SBRpLSj1rrckH5N1PtLpbH3phw4uqNbPSQH2Sw1
SNL40zAXpENHx1EPmjk08giZ2G5AsMVyRfJCZBYI4XS8/bBoIlvK76/Xvj/u2E3a
ft/KS45ZYxMr4KbfhVygnqBc+bNOBkm7a12u9siCznjHg9FpxA8bZLkC2Lo7dmxw
gcRD6XdqqFdmBZ8fRNWvXdHQAH3eyMjpxfmG+kc2HzZZUynxCm9VnOZj9/n/u5TF
9Dwt76P84EVjwAt7UFaAEAoarFPbNwQZ1AXEKd1CYRQtHzesg1HrcEsGdyfA5HjV
vZBjCxfOXLBG1QYwxvadoSMAiaV3erTDyNVQLuYXmmzUgRZ0Qe7pK8A/Wvqq+610
Bt9IoSbV4/DC2yFgoTiXRlbHSON1ENnaAimObEx0OwTqp+EolnT0cBsEJWaREe5K
a/QfcHNhVutN5vXdZRn9hZtxmsvvRArVCeUlkT6pKfuxCLvttPHrzhYk1ADzdWrI
wKDq2Ib/7OumQP9YwjsC
=8Pes
-----END PGP SIGNATURE-----

--J3rqiH0DIeiRD2zz--