From: Felipe Balbi <balbi@ti.com>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"ccross@android.com" <ccross@android.com>,
"olof@lixom.net" <olof@lixom.net>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"tony@atomide.com" <tony@atomide.com>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"jamie@jamieiles.com" <jamie@jamieiles.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: tegra: Add SMMU enabler in AHB
Date: Tue, 24 Apr 2012 16:25:37 +0300 [thread overview]
Message-ID: <20120424132536.GO8444@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120424.160319.1903472399760352200.hdoyu@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Tue, Apr 24, 2012 at 03:03:19PM +0200, Hiroshi Doyu wrote:
> > > Only Tegra3 has SMMU.
> >
> > but all of them ? In that case, you could call this from probe itself,
> > right ? But an ifdef won't work in all cases, so you need to do runtime
> > detection based on some revision register or cpu detection...
>
> So far we don't have so many variants, and presently TEGRA_3x_SOC
> always has a SMMU. If there were some variants of TEGRA_3x_SOC, where
> some might not have SMMU, then runtime detection would make sense
> there. Now it's something like TEGRA_3x_SOC == SMMU.
the problem is when you have single kernel for TEGRA 2 and TEGRA 3. If
you rely on ifdef, one of them won't work properly, right ? ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-24 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 12:05 [PATCH v2 1/3] ARM: tegra: Add AHB driver Hiroshi DOYU
2012-04-24 12:05 ` [PATCH v2 2/3] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-04-24 12:32 ` Felipe Balbi
2012-04-24 12:39 ` Hiroshi Doyu
2012-04-24 12:41 ` Felipe Balbi
2012-04-24 13:03 ` Hiroshi Doyu
2012-04-24 13:25 ` Felipe Balbi [this message]
2012-04-24 19:59 ` Russell King - ARM Linux
2012-04-24 12:05 ` [PATCH v2 3/3] iommu/tegra: smmu: Refrain from accessing to AHB registers Hiroshi DOYU
2012-04-24 12:16 ` [PATCH v2 1/3] ARM: tegra: Add AHB driver Felipe Balbi
2012-04-24 19:49 ` Stephen Warren
2012-04-24 20:31 ` Felipe Balbi
2012-04-24 19:56 ` Russell King - ARM Linux
2012-04-25 5:37 ` Hiroshi Doyu
2012-04-25 7:46 ` Felipe Balbi
2012-04-25 12:15 ` Arnd Bergmann
2012-04-25 15:59 ` Stephen Warren
2012-04-26 5:49 ` Hiroshi Doyu
2012-04-26 8:14 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424132536.GO8444@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=ccross@android.com \
--cc=hdoyu@nvidia.com \
--cc=hsweeten@visionengravers.com \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®