From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Hagen Paul Pfeifer <hagen@jauu.net>
Subject: Re: [GIT PULL 00/13] Annotation improvements (G+ edition)
Date: Wed, 25 Apr 2012 07:48:00 -0300 [thread overview]
Message-ID: <20120425104800.GC17992@infradead.org> (raw)
In-Reply-To: <20120425103132.GB17992@infradead.org>
After the bandaid, I see some strange constructs like (press 'o' to view
the original disassembly):
0.00 || 399f877dc6:v je 399f877dd5 <_int_free+0x735>
0.00 || 399f877dc8: lock decl (%r12)
0.00 |+------877dcd:^ jne 399f87bd64 <_L_unlock_5659>
0.00 | 399f877dd3:v jmp 399f877ddf <_int_free+0x73f>
There is a bug above, the start_width for the arrow is bigger than it
should, will fix.
Pressing 'o' again this becomes:
0.00 || v je 735
0.00 || lock decl (%r12)
0.00 |+------^ jne 0
0.00 | v jmp 73f
The 'jne 0' line, its a misparse of the <....> part, it ass-umed that a
+ was there all the time, which is not true, so I should instead do a
fixup when traversing the ->offsets array, looking for dl->target.ops =
0 and, since we know where the symbol starts at that point, fix it.
- Arnaldo
next prev parent reply other threads:[~2012-04-25 10:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 20:33 =?y?q?=5BGIT=20PULL=2000/13=5D=20Annotation=20improvements=20=28G+=20edition=29?= Arnaldo Carvalho de Melo
2012-04-19 20:33 ` [PATCH 01/13] perf annotate: Rename objdump_line to disasm_line Arnaldo Carvalho de Melo
2012-04-19 20:33 ` [PATCH 02/13] perf annotate: Parse instruction Arnaldo Carvalho de Melo
2012-04-19 23:55 ` David Ahern
2012-04-20 10:53 ` Arnaldo Carvalho de Melo
2012-04-23 6:30 ` Namhyung Kim
2012-04-19 20:33 ` [PATCH 03/13] perf annotate browser: Use the disasm_line instruction name and operand fields Arnaldo Carvalho de Melo
2012-04-19 20:33 ` [PATCH 04/13] perf annotate: Disassembler instruction parsing Arnaldo Carvalho de Melo
2012-04-19 20:34 ` [PATCH 05/13] perf annotate: Parse call targets earlier Arnaldo Carvalho de Melo
2012-04-19 20:34 ` [PATCH 06/13] perf annotate: Introduce scnprintf ins_ops method Arnaldo Carvalho de Melo
2012-04-19 20:34 ` [PATCH 07/13] perf annotate browser: Rename disasm_line_rb_node Arnaldo Carvalho de Melo
2012-04-19 20:34 ` [PATCH 08/13] perf symbols: Introduce symbol__size method Arnaldo Carvalho de Melo
2012-04-19 20:34 ` [PATCH 09/13] perf annotate browser: Hide non jump target addresses in offset mode Arnaldo Carvalho de Melo
2012-04-20 0:01 ` [GIT PULL 00/13] Annotation improvements (G+ edition) David Ahern
2012-04-20 10:51 ` Arnaldo Carvalho de Melo
2012-04-20 0:31 ` Linus Torvalds
2012-04-20 0:40 ` Linus Torvalds
2012-04-20 10:59 ` Arnaldo Carvalho de Melo
2012-04-25 7:05 ` Ingo Molnar
2012-04-25 10:31 ` Arnaldo Carvalho de Melo
2012-04-25 10:48 ` Arnaldo Carvalho de Melo [this message]
2012-04-23 1:17 George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425104800.GC17992@infradead.org \
--to=acme@infradead.org \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hagen@jauu.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®