mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Stephane Eranian" <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Arnaldo Carvalho de Melo" <acme@redhat.com>,
	mingo@elte.hu, "David Ahern" <dsahern@gmail.com>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Jiri Olsa" <jolsa@redhat.com>
Subject: Re: [BUG] perf stat: useless output for raw events with new event parser
Date: Thu, 26 Apr 2012 16:45:14 +0200	[thread overview]
Message-ID: <20120426144514.GB18810@erda.amd.com> (raw)
In-Reply-To: <1335450273.13683.76.camel@twins>

On 26.04.12 16:24:33, Peter Zijlstra wrote:
> On Thu, 2012-04-26 at 15:12 +0200, Robert Richter wrote:
> > On 26.04.12 12:27:11, Peter Zijlstra wrote:
> > > Furthermore, once we have a common format, we could even ask Intel/AMD
> > > (and other vendors) to provide their data in this format.
> > 
> > I don't think that can be done with a reasonable effort. 
> 
> I'm thinking you mis-understand, all we're talking about is a copy of
> your event list (BKDG Fam 10h Rev 3.48, section 3.14) in a usable
> format.

If it is not more complex than for libpfm4 am fine with it. I was
worried about describing pmu capabilities in sysfs which can better be
done with pmu specific code, once we know on which pmu we run.

> Its an aid to simplify constructing raw events, nothing more.
> 
> When I want to use funny events I'm staring at the Intel-SDM/AMD-BKDG
> anyway and I find writing:
> 
>   cpu/event=0x4e2,umask=0xf8/
> 
> A lot easier than:
> 
>   r40000f8e2

It is totally ok to have parser support for this. I simply do not see
why we need to put the encoding into sysfs. We somehow know on which
hardware we run and the parser should already know how to setup the
syscall. So parsing the above finally ends in calling of something
like:

 setup_event_for_some_pmu(event, 0x4e2, 0xf8);

We don't need any description of bit masks in sysfs for this.

> So I'd be perfectly ok with adding something
> like /sys/bus/events/device/*/name or so.

Yes, something like this could be added to let userland know about the
pmu.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center


  reply	other threads:[~2012-04-26 14:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 10:45 Stephane Eranian
2012-04-23 10:48 ` Peter Zijlstra
2012-04-23 10:55   ` Jiri Olsa
2012-04-23 10:56   ` Robert Richter
2012-04-23 11:17   ` Stephane Eranian
2012-04-26 10:27     ` Peter Zijlstra
2012-04-26 12:53       ` Stephane Eranian
2012-04-26 14:03         ` Peter Zijlstra
2012-04-26 13:12       ` Robert Richter
2012-04-26 14:24         ` Peter Zijlstra
2012-04-26 14:45           ` Robert Richter [this message]
2012-04-26 15:39             ` Peter Zijlstra
2012-04-26 17:36               ` Robert Richter
2012-05-07 12:42                 ` Peter Zijlstra
2012-05-07 16:58                   ` Robert Richter
2012-04-23 10:57 ` Jiri Olsa
2012-05-02 11:14 ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426144514.GB18810@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome