From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757199Ab2D0XZE (ORCPT ); Fri, 27 Apr 2012 19:25:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58805 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756069Ab2D0XZB (ORCPT ); Fri, 27 Apr 2012 19:25:01 -0400 Date: Fri, 27 Apr 2012 16:24:59 -0700 From: Andrew Morton To: David Rientjes Cc: Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki Subject: Re: inux-next: Tree for Apr 27 (uml + mm/memcontrol.c) Message-Id: <20120427162459.322d145a.akpm@linux-foundation.org> In-Reply-To: References: <20120427161146.95422142968526faaff615d4@canb.auug.org.au> <4F9ABF9C.2070707@xenotime.net> <20120427132343.fbb443b9.akpm@linux-foundation.org> <20120427143646.8209627e.akpm@linux-foundation.org> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Apr 2012 16:14:52 -0700 (PDT) David Rientjes wrote: > > Minor matter: that's non-responsive to my suggestion. > > > > If it's moved to a new cgroup then we can just go back to the original > point that I made as was trying to avoid: adding #ifdefs all over > mm/memcontrol.c in a dozen or so places. A mm/hugetlbcg.c would only be > built, natually, when we have "depends on HUGETLB_PAGE" and > linux/hugetlb.h takes care of the rest (setting HUGE_MAX_HSTATE for archs > that don't define it themselves, in other words only one hugepage size). And if it isn't moved to a new cgroup then your memcg-add-hugetlb-extension-fix.patch is suboptimal. Why is this so hard?