From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026Ab2D3MCY (ORCPT ); Mon, 30 Apr 2012 08:02:24 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:52260 "EHLO smtprelay-b12.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754849Ab2D3MCW (ORCPT ); Mon, 30 Apr 2012 08:02:22 -0400 X-SENDER-IP: [85.230.169.225] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AleFABF/nk9V5qnhPGdsb2JhbABEiiqmSASBGhkBAQEBHhkNJ4IJAQEEAScTHCMFCwgDDjgUDRgKGhOHfwMGCa9LDYlTE4l5gSiFC2MElX2GBoU6h20 X-IronPort-AV: E=Sophos;i="4.75,505,1330902000"; d="scan'208";a="102726691" From: "Henrik Rydberg" Date: Mon, 30 Apr 2012 14:06:41 +0200 To: Nikolai Kondrashov Cc: Jiri Kosina , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] hid: Enable report fixup on rebind Message-ID: <20120430120641.GA3111@polaris.bitmath.org> References: <1335097300-11881-1-git-send-email-rydberg@euromail.se> <4F9D5F43.4000502@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F9D5F43.4000502@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikolai, > >>The first two patches are bug fixes found in the process. I am hoping > >>for some test feedback on those. The third patch is the main one. > > I've tested the last patch and it seems to work as required. I did a series > of generic<->specific driver rebindings both ways in a loop and it works. > > So, > Tested-by: Nikolai Kondrashov Great, thanks! > I'm not sure, though, if one thing works as it should: the quirks are not > reset when changing the driver. So, quirks set by one driver may affect > behavior of another. I don't understand full quirks usage and ownership yet, > so can't argue if this is right or wrong. The common quirks are a device property, so this is fine. There are some drivers with quirks too, but they handle those themselves. > Regarding the code, could it be the time to fix naming of report > descriptor-handling functions to improve distinction from report-handling > ones? I'm attaching a patch applying on top of Henrik's changes which should > illustrate the proposal. The changes you propose force changes to out-of-tree-drivers, without any obvious benefit. Also, there is already a large set of patches on review based on this one. So although I agree that some renames and movements could clarify things, the content and timing will need some more thought. Thanks, Henrik