From: Greg KH <gregkh@linuxfoundation.org>
To: Preston Fick <pffick@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, preston.fick@silabs.com
Subject: Re: [PATCH] usb: cp210x: Added support for GPIO (CP2103/4/5)
Date: Mon, 30 Apr 2012 16:32:15 -0400 [thread overview]
Message-ID: <20120430203215.GA15589@kroah.com> (raw)
In-Reply-To: <1335817637-2862-1-git-send-email-preston.fick@silabs.com>
On Mon, Apr 30, 2012 at 03:27:17PM -0500, Preston Fick wrote:
> This fix contains several changes that allow toggling of GPIO on CP210x
> devices that support it. Changes include:
> * Added in part number support, necessary to see if the connected device
> supports the GPIO functionality
> * Added two IOCTLs and ioctl function to allow GET/SET of GPIO
> * Added in new #defines for partnum support, new USB requests
> * Changed "Config request types" section to contain more correct definitions
> for request recipient
No, please break this out into one-patch-per-change, don't bundle all of
this together into one, as I can't take it as-is, sorry.
Especially with those new ioctls...
thanks,
greg k-h
next prev parent reply other threads:[~2012-04-30 20:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 20:27 Preston Fick
2012-04-30 20:32 ` Greg KH [this message]
2012-05-03 20:34 ` Alan Cox
2012-05-04 15:27 ` Preston Fick
2012-05-05 0:32 ` Greg KH
2012-05-05 11:01 ` Alan Cox
2012-05-05 14:57 ` Greg KH
2012-05-16 15:33 ` Alan Cox
2012-05-16 23:41 ` Greg KH
2012-05-04 16:26 ` Alexander Stein
2012-05-04 16:33 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2012-04-28 16:55 Preston Fick
2012-04-28 18:05 ` Alan Cox
2012-04-28 18:17 ` Uwe Bonnes
2012-04-28 19:33 ` Alan Cox
2012-04-29 13:02 ` Uwe Bonnes
2012-04-29 14:35 ` Xiaofan Chen
2012-04-28 20:30 ` Preston Fick
2012-04-28 21:08 ` Alan Cox
2012-04-28 21:44 ` Preston Fick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430203215.GA15589@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pffick@gmail.com \
--cc=preston.fick@silabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome