From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755092Ab2ECBFT (ORCPT ); Wed, 2 May 2012 21:05:19 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:38294 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466Ab2ECBFR (ORCPT ); Wed, 2 May 2012 21:05:17 -0400 Date: Wed, 02 May 2012 21:05:09 -0400 (EDT) Message-Id: <20120502.210509.1240046301942391500.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: levinsasha928@gmail.com, jchapman@katalix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davej@redhat.com Subject: Re: [PATCH v2] net: l2tp: unlock socket lock before returning from l2tp_ip_sendmsg From: David Miller In-Reply-To: <1335969156.22133.570.camel@edumazet-glaptop> References: <1335967123-2588-1-git-send-email-levinsasha928@gmail.com> <1335969156.22133.570.camel@edumazet-glaptop> X-Mailer: Mew version 6.5 on Emacs 24.0.95 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Wed, 02 May 2012 18:05:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Wed, 02 May 2012 16:32:36 +0200 > On Wed, 2012-05-02 at 15:58 +0200, Sasha Levin wrote: >> l2tp_ip_sendmsg could return without releasing socket lock, making it all the >> way to userspace, and generating the following warning: >> >> [ 130.891594] ================================================ >> [ 130.894569] [ BUG: lock held when returning to user space! ] >> [ 130.897257] 3.4.0-rc5-next-20120501-sasha #104 Tainted: G W >> [ 130.900336] ------------------------------------------------ >> [ 130.902996] trinity/8384 is leaving the kernel with locks still held! >> [ 130.906106] 1 lock held by trinity/8384: >> [ 130.907924] #0: (sk_lock-AF_INET){+.+.+.}, at: [] l2tp_ip_sendmsg+0x2f/0x550 >> >> Introduced by commit 2f16270 ("l2tp: Fix locking in l2tp_ip.c"). >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Sasha Levin >> --- > > Oh well, please read Documentation/stable_kernel_rules.txt > > Also, David prefers to handle stable submissions himself for net tree. > > Anyway : > > Acked-by: Eric Dumazet Applied.