From: Joe Korty <joe.korty@ccur.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Andy Whitcroft <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch: kstrtol fix
Date: Wed, 2 May 2012 13:13:18 -0400 [thread overview]
Message-ID: <20120502171318.GA2103@tsunami.ccur.com> (raw)
In-Reply-To: <1335975202.2324.12.camel@groeck-laptop>
On Wed, May 02, 2012 at 12:13:22PM -0400, Guenter Roeck wrote:
> On Wed, 2012-05-02 at 11:10 -0400, Joe Korty wrote:
>> kstrtol is a substitute for simple_strtol() only when when second
>> arg of simple_strtol() is NULL. For any other value the functionality
>> of simple_strtol() cannot be implemented in terms of kstrtol.
>
> If there _are_ uses of
> simple_strtol() where the second argument is not used for error checking
> but for some other purpose, I am sure that an alternative solution can
> be found which does not require simple_strtol(). Or just live with the
> warning for those cases.
>
> Thanks,
> Guenter
And of course the burning question is, what was the compelling reason
kstrtol wasn't made upwards-compatible with strtol? It just seems
gratituous to have that little bit of incompatibility introduced
into the kernel.
Joe
prev parent reply other threads:[~2012-05-02 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 15:10 Joe Korty
2012-05-02 16:13 ` Guenter Roeck
2012-05-02 17:13 ` Joe Korty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502171318.GA2103@tsunami.ccur.com \
--to=joe.korty@ccur.com \
--cc=apw@canonical.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome