From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
bruce.e.robertson@intel.com, "Pallala,
Ramakrishna" <ramakrishna.pallala@intel.com>
Subject: Re: [PATCH 4/4] power-supply: smb347-charger: convert to regmap API
Date: Sun, 6 May 2012 09:34:40 +0300 [thread overview]
Message-ID: <20120506063440.GF31494@intel.com> (raw)
In-Reply-To: <20120505125211.GA31577@lizard>
On Sat, May 05, 2012 at 05:52:11AM -0700, Anton Vorontsov wrote:
>
> I fixed this by the following change:
>
> diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
> index 1f27d21..cf31b31 100644
> --- a/drivers/power/smb347-charger.c
> +++ b/drivers/power/smb347-charger.c
> @@ -459,7 +459,8 @@ static int smb347_set_voltage_limits(struct smb347_charger *smb)
> static int smb347_set_temp_limits(struct smb347_charger *smb)
> {
> bool enable_therm_monitor = false;
> - int ret, val;
> + int ret = 0;
> + int val;
>
> if (smb->pdata->chip_temp_threshold) {
> val = smb->pdata->chip_temp_threshold;
>
> Please check if that's all OK.
Looks ok to me. Thanks for fixing it.
next prev parent reply other threads:[~2012-05-06 6:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 8:48 [PATCH 1/4] power-supply: smb347-charger: convert to use module_i2c_driver() Mika Westerberg
2012-04-16 8:48 ` [PATCH 2/4] power-supply: smb347-charger: rename few functions to match better what they are doing Mika Westerberg
2012-04-16 8:48 ` [PATCH 3/4] power-supply: smb347-charger: move IRQ enabling to the end of probe Mika Westerberg
2012-04-16 8:48 ` [PATCH 4/4] power-supply: smb347-charger: convert to regmap API Mika Westerberg
2012-05-05 12:52 ` Anton Vorontsov
2012-05-06 6:34 ` Mika Westerberg [this message]
2012-05-05 12:56 ` [PATCH 1/4] power-supply: smb347-charger: convert to use module_i2c_driver() Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506063440.GF31494@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=bruce.e.robertson@intel.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome