On Mon, May 07, 2012 at 01:05:39PM +0530, Laxman Dewangan wrote: > Settling time is require when there is voltage output change. > Implement set_voltage_time_sel() callback which returns delay time > for voltage change to settle down to new value. This is fine but depends on your previous stylistic change so won't apply. In general you should always try to order things so that there are fewer dependencies at the start of the series - there's no actual dependency between this and the stylistic changes you've made.