On Mon, May 07, 2012 at 08:15:13PM +0530, Laxman Dewangan wrote: > Actually I saw the multiple driver which uses > set_bits()/clear_bits() and thought that this is good way of writing > clean code and so developed multiple driver surrounding these apis. > Now seems it is easy for me to use these apis. May be it is my > personal taste. It's a taste thing, a lot of those drivers are doing this because they cloned the wm8350 driver (or something else which was based off the wm8350 driver - it was the first of these).