From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/3] tty_lock: Localise the lock
Date: Mon, 7 May 2012 17:11:26 +0100 [thread overview]
Message-ID: <20120507171126.5beddc27@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CA+1xoqezLCQh_fqJ1iNAs25X7Fm24W=-0J8zTZuVVJQnWTtSLg@mail.gmail.com>
> I don't believe that this change is correct.
>
> Consider the following scenario:
>
> tty_release -> tty_lock -> pty_close -> tty_vhangup -> tty_lock
We hang up tty->link not tty.
It's now a per tty lock. So I think we are ok.
Alan
next prev parent reply other threads:[~2012-05-07 16:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 21:21 [PATCH 1/3] tty_lock: undo the old tty_lock use on the ctty Alan Cox
2012-05-03 21:22 ` [PATCH 2/3] pty: Lock the devpts bits privately Alan Cox
2012-05-08 18:18 ` H. Peter Anvin
2012-05-08 20:43 ` Alan Cox
2012-05-08 20:41 ` H. Peter Anvin
2012-05-03 21:24 ` [PATCH 3/3] tty_lock: Localise the lock Alan Cox
2012-05-04 20:48 ` Arnd Bergmann
2012-05-04 23:54 ` Greg KH
2012-05-04 23:55 ` Greg KH
2012-05-07 16:03 ` Sasha Levin
2012-05-07 16:11 ` Alan Cox [this message]
2012-05-07 16:30 ` Sasha Levin
2012-05-07 16:42 ` Alan Cox
2012-05-07 17:00 ` Sasha Levin
2012-05-07 21:04 ` Jiri Slaby
2012-05-08 18:12 ` Sasha Levin
2012-05-11 10:40 ` Sasha Levin
2012-05-11 14:52 ` Greg KH
2012-05-11 15:09 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507171126.5beddc27@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®