From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: Regression due to d29f3ef "tty_lock: Localise the lock"
Date: Tue, 8 May 2012 10:35:12 +0100 [thread overview]
Message-ID: <20120508103512.42db1c4b@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <4FA8557E.5080402@wwwdotorg.org>
On Mon, 07 May 2012 17:06:38 -0600
Stephen Warren <swarren@wwwdotorg.org> wrote:
> Alan,
>
> Commit d29f3ef "tty_lock: Localise the lock" appears to cause a problem
> for me.
>
> With this commit (as in next-20120507), I can no longer log into my
> system (NVIDIA Tegra device with ARM CPU) over the serial console, since
> the login prompt no longer appears. If I wait a few minutes, I see the
> following console spew:
Eep. If it's reproducable can you test whether adding the unlock/relock
in drivers/tty/pty.c does the trick ?
ie:
tty_unlock(tty);
tty_vhangup(tty);
tty_lock(tty);
or if changing it for tty_hangup(tty) does it.
There's some kind of lurking circular locking deadlock that I've not
managed to trigger here but a couple of reports point towards.
next prev parent reply other threads:[~2012-05-08 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 23:06 Stephen Warren
2012-05-08 9:35 ` Alan Cox [this message]
2012-05-08 15:46 ` Stephen Warren
2012-05-08 16:04 ` Alan Cox
2012-05-08 16:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508103512.42db1c4b@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®