Re: [PATCH v2] staging: comedi: remove __user annotation inside of struct's

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, May 09, 2012 at 09:36:03AM -0700, H Hartley Sweeten wrote:
> Remove the __user annotations in the struct definitions in
> comedi.h.
> 
> These structs are used to pass information from user-space
> to kernel-space. The copy_from_user and copy_to_user functions
> are used to transfer the data between the address spaces.
> 
> The drivers then use the information internally under the
> assumption that they are kernel-space objects. Having the
> __user annotations inside the structs produces a number of
> sparse warnings of the type:
> 
> warning: dereference of noderef expression
> 
> According to Grek Kroah-Hartman:
> 
> "When the kernel exports .h files, stuff like this should work
> "automatically", so there is no need to not put __user markings."

Wait, for some reason I thought you were adding __user markings, not
removing them from the structures.  That is why I said the above
statement.

Why again are you removing them?  Didn't you just cause more sparse
warnings to pop up?

confused,

greg k-h