From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754409Ab2EKHU4 (ORCPT ); Fri, 11 May 2012 03:20:56 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:41113 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503Ab2EKHUy (ORCPT ); Fri, 11 May 2012 03:20:54 -0400 Date: Fri, 11 May 2012 00:20:49 -0700 From: Dmitry Torokhov To: Peter Ujfalusi Cc: Paul Gortmaker , Sasha Levin , broonie@opensource.wolfsonicro.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] TWL6040: fix build error Message-ID: <20120511072049.GA9088@core.coreip.homeip.net> References: <1336675473-24774-1-git-send-email-levinsasha928@gmail.com> <4FACB9D7.5090100@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FACB9D7.5090100@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote: > Hi, > > On 05/11/2012 01:49 AM, Paul Gortmaker wrote: > > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin wrote: > >> Fixes build error due to missing of_property_read_u32. > > > > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to > > this missing header, it needs to have a Kconfig dependency that limits > > it to just being enabled on the platforms where it physically is possible to > > have the hardware. I'm guessing limiting to ARM would be a good start? > > Yes it is only usable on ARM, most specifically on OMAP4+ platforms. > If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this > won't happen again. Is there any other errors beside missing include of.h (and extra of_device.h?). The driver seems to be compiling fine on x86_64 so no need to limit to ARM only... Thanks. -- Dmitry