Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
> The warning shown up when ran with randconfig,
> 
> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
> 
> Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
> ---
>  drivers/usb/dwc3/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index d8f741f..68271fa 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,6 +1,6 @@
>  config USB_DWC3
>  	tristate "DesignWare USB3 DRD Core Support"
> -	depends on (USB && USB_GADGET)
> +	depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
					      ^^^^
					      typo

I would prefer the select to change:

select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)

or something similar.

>  	select USB_OTG_UTILS
>  	select USB_GADGET_DUALSPEED
>  	select USB_GADGET_SUPERSPEED

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]