From: Borislav Petkov <bp@amd64.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Borislav Petkov <bp@amd64.org>,
Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Doug Thompson <norsk5@yahoo.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v.23-2] RAS: use tracepoint to handle hw issues
Date: Sat, 12 May 2012 00:31:13 +0200 [thread overview]
Message-ID: <20120511223113.GA18908@aftab.osrc.amd.com> (raw)
In-Reply-To: <4FAD4806.2010507@redhat.com>
On Fri, May 11, 2012 at 02:10:30PM -0300, Mauro Carvalho Chehab wrote:
> Well, tell me what title you want for this patch, instead of coming
> with offending comments like above, and I'll change it to match your
> desire.
Already told you but here it is again:
> Let me repeat myself:
>
> > It should be:
> >
> > Subject: RAS: Add a tracepoint for reporting memory controller errors
> >
> > and not
> >
> > Subject: edac, ras/hw_event.h: use events to handle hw issues
> >
> > because events don't handle hw issues.
>
> You don't use events to handle hardware issues - you use tracepoints to
> report hardware issues! And besides, "event" is so overloaded in kernel
> land that actually refraining from its use makes me keep at least a bit
> of sanity when looking at yet another header called something event.h.
>
> Please be more precise when naming your patches.
>
> Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-05-11 22:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 19:56 [PATCH v22] edac, ras/hw_event.h: use events " Mauro Carvalho Chehab
2012-05-10 20:40 ` Borislav Petkov
2012-05-10 20:55 ` Mauro Carvalho Chehab
2012-05-10 22:46 ` Steven Rostedt
2012-05-10 23:16 ` Mauro Carvalho Chehab
2012-05-10 21:00 ` [PATCHv23] RAS: " Mauro Carvalho Chehab
2012-05-11 10:04 ` Borislav Petkov
2012-05-11 14:54 ` [PATCH v.23-2] RAS: use tracepoint " Mauro Carvalho Chehab
2012-05-11 17:02 ` Luck, Tony
2012-05-11 18:53 ` Mauro Carvalho Chehab
2012-05-11 20:07 ` Tony Luck
2012-05-11 17:06 ` Borislav Petkov
2012-05-11 17:10 ` Mauro Carvalho Chehab
2012-05-11 22:31 ` Borislav Petkov [this message]
2012-05-11 22:35 ` Luck, Tony
2012-05-12 14:13 ` [PATCH v24] RAS: Add a tracepoint for reporting memory controller events Mauro Carvalho Chehab
2012-05-10 21:10 ` [PATCH v22] edac, ras/hw_event.h: use events to handle hw issues Luck, Tony
2012-05-10 22:07 ` Mauro Carvalho Chehab
2012-05-10 22:37 ` Luck, Tony
2012-05-11 1:48 ` Mauro Carvalho Chehab
2012-05-11 10:25 ` Borislav Petkov
2012-05-11 12:37 ` Mauro Carvalho Chehab
2012-05-11 17:24 ` Borislav Petkov
2012-05-11 18:38 ` Mauro Carvalho Chehab
2012-05-14 13:34 ` Borislav Petkov
2012-05-14 14:27 ` Mauro Carvalho Chehab
2012-05-15 15:09 ` Borislav Petkov
2012-05-15 16:05 ` Mauro Carvalho Chehab
2012-05-15 16:38 ` Borislav Petkov
2012-05-16 11:22 ` Mauro Carvalho Chehab
2012-05-16 13:16 ` Borislav Petkov
2012-05-16 13:27 ` Steven Rostedt
2012-05-16 13:32 ` Borislav Petkov
2012-05-16 13:47 ` Steven Rostedt
2012-05-16 15:16 ` Mauro Carvalho Chehab
2012-05-16 15:47 ` Borislav Petkov
2012-05-16 16:52 ` Mauro Carvalho Chehab
2012-05-16 19:59 ` Borislav Petkov
2012-05-16 20:27 ` Luck, Tony
2012-05-16 21:05 ` Borislav Petkov
2012-05-16 12:48 ` Steven Rostedt
2012-05-16 15:24 ` Mauro Carvalho Chehab
2012-05-16 17:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511223113.GA18908@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=fweisbec@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@redhat.com \
--cc=norsk5@yahoo.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome