From: Arnd Bergmann <arnd@arndb.de>
To: adam radford <aradford@gmail.com>
Cc: mathieu.poirier@linaro.org, JBottomley@parallels.com,
megaraidlinux@lsi.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] scsi/megaraid: fix sparse warnings
Date: Sat, 12 May 2012 13:02:21 +0000 [thread overview]
Message-ID: <201205121302.21623.arnd@arndb.de> (raw)
In-Reply-To: <CAHtARFFnLrk0zQ7GeoiPX3Cyso9zq-05q+RyyeGN0v7q=Dm1gQ@mail.gmail.com>
On Friday 11 May 2012, adam radford wrote:
>
> On Fri, May 11, 2012 at 3:09 PM, <mathieu.poirier@linaro.org> wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> ...
> > diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > index bfd87fa..234ad74 100644
> > --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > @@ -51,55 +51,16 @@
> > #include <scsi/scsi_device.h>
> > #include <scsi/scsi_host.h>
> >
> > +#include "mega_common.h"
>
> Do not include mega_common.h in the megaraid_sas driver. It has
> nothing to do with this driver. It is for the older Parallel SCSI
> megaraid drivers.
Ok. I think I first tried moving all declarations into mega_common.h
and then decided otherwise but forgot to remove that #include statement
again. Thanks for taking a look!
Arnd
next prev parent reply other threads:[~2012-05-12 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 22:09 [PATCH 0/7] drivers/scsi: randconfig patches for kernel 3.4.patch mathieu.poirier
2012-05-11 22:09 ` [PATCH 1/7] scsi: mark SCSI_SRP as experimental mathieu.poirier
2012-05-11 22:09 ` [PATCH 2/7] scsi/nsp32: don't pass large values into udelay mathieu.poirier
2012-05-11 22:09 ` [PATCH 3/7] drivers/scsi: use correct __devexit_p annotation mathieu.poirier
2012-05-11 22:09 ` [PATCH 4/7] scsi/advansys: do not build on ARM mathieu.poirier
2012-05-11 22:09 ` [PATCH 5/7] scsi/atp870u: use mdelay instead of large udelay mathieu.poirier
2012-05-11 22:09 ` [PATCH 6/7] scsi/megaraid: fix sparse warnings mathieu.poirier
2012-05-11 22:29 ` adam radford
2012-05-12 13:02 ` Arnd Bergmann [this message]
2012-05-11 22:09 ` [PATCH 7/7] drivers/scsi: some ISA drivers need ISA_DMA_API mathieu.poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205121302.21623.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=JBottomley@parallels.com \
--cc=aradford@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=megaraidlinux@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®