From: Borislav Petkov <bp@amd64.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Chen Gong <gong.chen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, "Huang, Ying" <ying.huang@intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] x86/mce: Add instruction recovery signatures to mce-severity table
Date: Sun, 13 May 2012 12:05:32 +0200 [thread overview]
Message-ID: <20120513100532.GC28863@aftab.osrc.amd.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F192ED617@ORSMSX104.amr.corp.intel.com>
On Fri, May 11, 2012 at 05:42:09PM +0000, Luck, Tony wrote:
> > For IFU, on affected logical processors, RIPV and EIPV both are 0,
> > since now new IFU entries are added into severity table, the old
> > entry as below should be removed:
> >
> > /* Neither return not error IP -- no chance to recover -> PANIC */
> > MCESEV(
> > PANIC, "Neither restart nor error IP",
> > MCGMASK(MCG_STATUS_RIPV|MCG_STATUS_EIPV, 0)
> > ),
>
> We need to keep this. If EIPV is not set, then CS and IP on the
> stack are not guaranteed ... so we can't tell whether the error
> happened in user or kernel mode. This makes recovery "challenging".
>
> I'm trying to figure out a quirk for processors that do generate
> EIPV=RIPV=0 signature for IFU errors. There are some case where
> we can work around the lack of EIPV.
__mcheck_cpu_apply_quirks?
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-05-13 10:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 18:33 [PATCH 0/2] Add machine check recovery for instruction fetch Tony Luck
2012-05-10 18:01 ` [PATCH 1/2] x86/mce: Only restart instruction after machine check recovery if it is safe Tony Luck
2012-05-11 7:19 ` Chen Gong
2012-05-11 16:23 ` Luck, Tony
2012-05-13 9:59 ` Borislav Petkov
2012-05-14 16:16 ` Luck, Tony
2012-05-14 17:17 ` Borislav Petkov
2012-05-14 18:02 ` Tony Luck
2012-05-14 21:55 ` Borislav Petkov
2012-05-10 18:12 ` [PATCH 2/2] x86/mce: Add instruction recovery signatures to mce-severity table Tony Luck
2012-05-11 7:40 ` Chen Gong
2012-05-11 17:42 ` Luck, Tony
2012-05-13 10:05 ` Borislav Petkov [this message]
2012-05-14 16:28 ` Luck, Tony
2012-05-14 17:23 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120513100532.GC28863@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome