From: David Miller <davem@davemloft.net>
To: bpoirier@suse.de
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xfrm: take iphdr size into account for esp payload size calculation
Date: Mon, 14 May 2012 18:39:52 -0400 (EDT) [thread overview]
Message-ID: <20120514.183952.1459413342269893446.davem@davemloft.net> (raw)
In-Reply-To: <1336698442-25148-1-git-send-email-bpoirier@suse.de>
From: Benjamin Poirier <bpoirier@suse.de>
Date: Thu, 10 May 2012 21:07:22 -0400
> - return mtu - 2;
> + return ((mtu - x->props.header_len - crypto_aead_authsize(esp->aead) -
> + l3_adj) & ~(align - 1)) + (l3_adj - 2);
> }
The formatting of this expression is completely wrong, you need
to make the "l3_adj" in the second line be aligned with the openning
parenthesis on the previous line at a depth determined based upon
how deeply in the openning parenthesis context this expression sits.
Just using TABS is ugly, and not allowed.
Use something like emacs's "C mode" with Linux coding style enabled
to assist you if you can't figure it out yourself.
next prev parent reply other threads:[~2012-05-14 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:35 [PATCH] " Benjamin Poirier
2012-05-10 12:18 ` Steffen Klassert
2012-05-11 1:02 ` Benjamin Poirier
2012-05-11 1:07 ` [PATCH v2] " Benjamin Poirier
2012-05-14 22:39 ` David Miller [this message]
2012-05-16 19:35 ` [PATCH v3] " Benjamin Poirier
2012-05-18 0:05 ` David Miller
2012-05-24 21:32 ` [PATCH v4] xfrm: take net hdr len " Benjamin Poirier
2012-05-27 5:09 ` David Miller
2012-05-11 10:39 ` [PATCH] xfrm: take iphdr size " Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514.183952.1459413342269893446.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bpoirier@suse.de \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®